From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754248AbdCJEcN (ORCPT ); Thu, 9 Mar 2017 23:32:13 -0500 Received: from mga04.intel.com ([192.55.52.120]:60179 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752817AbdCJEcM (ORCPT ); Thu, 9 Mar 2017 23:32:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,138,1486454400"; d="scan'208";a="234441086" Date: Fri, 10 Mar 2017 10:03:11 +0530 From: Vinod Koul To: Ramiro Oliveira Cc: Mike Looijmans , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , CARLOS.PALMINHA@synopsys.com Subject: Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC Message-ID: <20170310043311.GV2843@localhost> References: <1ff465a7-69ed-6cd1-0e02-4b9ff752b3cd@topic.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 09, 2017 at 09:55:59AM +0000, Ramiro Oliveira wrote: > Hi Mike > > On 3/9/2017 7:37 AM, Mike Looijmans wrote: > > On 06-03-17 13:27, Ramiro Oliveira wrote: > >> Add option in Kconfig to use Xilinx VDMA in ARC processors. > >> > >> Signed-off-by: Ramiro Oliveira > >> --- > >> drivers/dma/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > >> index 263495d0adbd..b6b6c0581ad7 100644 > >> --- a/drivers/dma/Kconfig > >> +++ b/drivers/dma/Kconfig > >> @@ -546,7 +546,7 @@ config XGENE_DMA > >> > >> config XILINX_DMA > >> tristate "Xilinx AXI DMAS Engine" > >> - depends on (ARCH_ZYNQ || MICROBLAZE || ARM64) > >> + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC) > > > > One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and then > > use it on any platform that supports PCIe. > > > > I've had to remove this line in order to be able to use the engine on an x86 > > desktop. > > > > How about plainly removing this "depends on" line and be done with it, instead > > of adding platforms one by one? > > > > > > I agree with you. From my point of view it would be better to remove this line > entirely. I'm just not sure if everyone agrees. if it works on others, compiles fine then there should not be an issue to remove. Feel free to send the patch. -- ~Vinod