Re: [f2fs-dev] [PATCH 1/2] f2fs: le16_to_cpu for xattr->e_value_size

Kinglong Mee
2017-03-11T00:05:13Z

On 3/11/2017 01:53, Jaegeuk Kim wrote:
> This patch fixes missing le16 conversion, reported by kbuild test robot.
>
> Fixes: 5f35a2cd5 ("f2fs: Don't update the xattr data that same as the exist")
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Kinglong Mee <kinglongmee@gmail.com>

> ---
> fs/f2fs/xattr.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
> index 7298a4488f7f..aff7619e3f96 100644
> --- a/fs/f2fs/xattr.c
> +++ b/fs/f2fs/xattr.c
> @@ -546,7 +546,9 @@ static bool f2fs_xattr_value_same(struct f2fs_xattr_entry *entry,
> const void *value, size_t size)
> {
> void *pval = entry->e_name + entry->e_name_len;
> - return (entry->e_value_size == size) && !memcmp(pval, value, size);
> +
> + return (le16_to_cpu(entry->e_value_size) == size) &&
> + !memcmp(pval, value, size);
> }
>
> static int __f2fs_setxattr(struct inode *inode, int index,
>