public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
	James Hogan <james.hogan@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
	Paul Burton <paul.burton@imgtec.com>
Subject: Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table
Date: Fri, 10 Mar 2017 10:22:01 -0800	[thread overview]
Message-ID: <20170310182201.GE21811@dtor-ws> (raw)
In-Reply-To: <20170310133307.10254-2-javier@osg.samsung.com>

On Fri, Mar 10, 2017 at 10:33:06AM -0300, Javier Martinez Canillas wrote:
> The OF device ID table doesn't have a sentinel NULL entry and so it
> causes the following error:
> 
> FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
> Makefile:1493: recipe for target 'modules' failed
> make: *** [modules] Error 2
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

This was also causing issues with 0-day builder when driver is built
into the kernel.

> ---
> 
>  drivers/auxdisplay/img-ascii-lcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
> index bf43b5d2aafc..73bc826144d4 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
>  	{ .compatible = "img,boston-lcd", .data = &boston_config },
>  	{ .compatible = "mti,malta-lcd", .data = &malta_config },
>  	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
> +	{ /* sentinel */ },
>  };
>  
>  /**
> -- 
> 2.9.3
> 

-- 
Dmitry

  reply	other threads:[~2017-03-10 18:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 13:33 [RESEND PATCH 0/2] auxdisplay: img-ascii-lcd: Trivial fixes Javier Martinez Canillas
2017-03-10 13:33 ` [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table Javier Martinez Canillas
2017-03-10 18:22   ` Dmitry Torokhov [this message]
2017-03-16 18:25     ` Dmitry Torokhov
2017-03-16 18:38       ` Javier Martinez Canillas
2017-03-16 18:41         ` Dmitry Torokhov
2017-03-16 18:48           ` Javier Martinez Canillas
2017-03-10 13:33 ` [RESEND PATCH 2/2] auxdisplay: img-ascii-lcd: Fix module autoload Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170310182201.GE21811@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=james.hogan@imgtec.com \
    --cc=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=paul.burton@imgtec.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox