From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755558AbdCJSuR (ORCPT ); Fri, 10 Mar 2017 13:50:17 -0500 Received: from mail.kernel.org ([198.145.29.136]:50846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932179AbdCJSuI (ORCPT ); Fri, 10 Mar 2017 13:50:08 -0500 Date: Fri, 10 Mar 2017 10:50:05 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH] f2fs: restrict write IO alignment condition Message-ID: <20170310185005.GC22979@jaegeuk.local> References: <20170310093804.35928-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170310093804.35928-1-yuchao0@huawei.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10, Chao Yu wrote: > We should only align start offset of bio with defined IO_SIZE for below > conditions: > a. write IOs > b. Out-place-update > c. non-meta page > > Signed-off-by: Chao Yu > --- > fs/f2fs/data.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 1375fef11146..3e6b0cc5e36a 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -395,7 +395,9 @@ int f2fs_submit_page_mbio(struct f2fs_io_info *fio) > __submit_merged_bio(io); > alloc_new: > if (io->bio == NULL) { > - if ((fio->type == DATA || fio->type == NODE) && > + if (!is_read && (fio->type == DATA || fio->type == NODE) && > + bio_page->mapping != META_MAPPING(sbi) && BUG_ON(), since it's covered by fio->type == DATA || fio->type == NODE. > + fio->new_blkaddr != fio->old_blkaddr && BUG_ON(), since LFS mount option doesn't allow any in-place updates. > fio->new_blkaddr & F2FS_IO_SIZE_MASK(sbi)) { So, is_read is worth to check? Thanks, > err = -EAGAIN; > if (!is_read) > -- > 2.8.2.295.g3f1c1d0