From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932715AbdCKMiX (ORCPT ); Sat, 11 Mar 2017 07:38:23 -0500 Received: from mga14.intel.com ([192.55.52.115]:35689 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbdCKMiP (ORCPT ); Sat, 11 Mar 2017 07:38:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,146,1486454400"; d="scan'208";a="1107311754" Date: Sat, 11 Mar 2017 14:38:09 +0200 From: Jarkko Sakkinen To: tpmdd-devel@lists.sourceforge.net Cc: linux-security-module@vger.kernel.org, Jerry Snitselaar , gang.wei@intel.com, Peter Huewe , Marcel Selhorst , Jason Gunthorpe , open list Subject: Re: [PATCH RFC,v2] tpm_crb: request and relinquish locality 0 Message-ID: <20170311123809.pa6gdh3tbdvcod55@intel.com> References: <20170311105339.19486-1-jarkko.sakkinen@linux.intel.com> <20170311105543.gkj46ktz6kup3bu5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170311105543.gkj46ktz6kup3bu5@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 11, 2017 at 12:55:43PM +0200, Jarkko Sakkinen wrote: > On Sat, Mar 11, 2017 at 12:53:36PM +0200, Jarkko Sakkinen wrote: > > Added two new callbacks to struct tpm_class_ops: > > > > - request_locality > > - relinquish_locality > > > > These are called before sending and receiving data from the TPM. > > > > Signed-off-by: Jarkko Sakkinen > > --- > > This not yet v2 of this patch. I'm checking that this is what needs to be done > > for tpm_tis_core before I go through testing etc. Thank you. > > And apparently I did not amend tpm-interface.c change :( Anyway, I'm > merely sanity checking that I'm doing the right thing. If check_locality fails request_locality returns locality number but it's not used for anything. Would it be OK to change it to just return -EBUSY in this case? /Jarkko