From: Greg KH <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()
Date: Sun, 12 Mar 2017 14:54:23 +0100 [thread overview]
Message-ID: <20170312135423.GA911@kroah.com> (raw)
In-Reply-To: <20170310133504.GA18916@singhal-Inspiron-5558>
On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
> The function atomisp_set_stop_timeout on being called, simply returns
> back. The function hasn't been mentioned in the TODO and doesn't have
> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
> removed.
>
> This was done using Coccinelle.
>
> @@
> identifier f;
> @@
>
> void f(...) {
>
> -return;
>
> }
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
> v1:
> -Change Subject to include name of function
> -change commit message to include the coccinelle script
You should also cc: the developers doing all of the current work on this
driver, Alan Cox, to get their comment if this really is something that
can be removed or not.
thanks,
greg k-h
next prev parent reply other threads:[~2017-03-12 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 13:35 [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout() simran singhal
2017-03-12 13:54 ` Greg KH [this message]
2017-03-12 15:44 ` SIMRAN SINGHAL
2017-03-12 15:47 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170312135423.GA911@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox