public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andrii <tulup@mail.ru>
Cc: sergio.paracuellos@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings
Date: Sun, 12 Mar 2017 15:16:34 +0100	[thread overview]
Message-ID: <20170312141634.GC29303@kroah.com> (raw)
In-Reply-To: <20170311223956.79ded6a2@andrii-VirtualBox>

On Sat, Mar 11, 2017 at 10:39:56PM +0200, Andrii wrote:
> Fixed code style warnings reported by checkpatch.pl script.

What warning would that be?  Please always be very specific.

> 
> Signed-off-by: Andrii Vladyka <tulup@mail.ru> 

Trailing whitespace on this line :(


> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 6134eba..d7d2d13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1346,14 +1346,10 @@ hfa384x_docmd(struct hfa384x *hw,
>  	} else if (mode == DOWAIT) {
>  		struct usbctlx_cmd_completor completor;
>  
> -		result =
> -		    hfa384x_usbctlx_complete_sync(hw, ctlx,
> -						  init_cmd_completor(&completor,
> -								     &ctlx->
> -								     inbuf.
> -								     cmdresp,
> -								     &cmd->
> -								     result));
> +		result = hfa384x_usbctlx_complete_sync(hw, ctlx,
> +						init_cmd_completor(&completor,
> +							&ctlx->inbuf.cmdresp,
> +							&cmd->result));

It's still a pain to read, can't there be a better way to rewite the
code to be readable?

thanks,

greg k-h

  reply	other threads:[~2017-03-12 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11 20:39 [PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings Andrii
2017-03-12 14:16 ` Greg KH [this message]
2017-03-12 15:30 ` [PATCHv2] staging: wlan-ng: fix avoid multiple line dereference warning reported by checkpatch.pl Andrii
2017-03-12 15:42   ` Greg KH
2017-03-12 15:47     ` Andrii
2017-03-12 16:24       ` Greg KH
2017-03-29  7:32   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312141634.GC29303@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=tulup@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox