From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933914AbdCLORE (ORCPT ); Sun, 12 Mar 2017 10:17:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47176 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755750AbdCLOQz (ORCPT ); Sun, 12 Mar 2017 10:16:55 -0400 Date: Sun, 12 Mar 2017 15:16:34 +0100 From: Greg KH To: Andrii Cc: sergio.paracuellos@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings Message-ID: <20170312141634.GC29303@kroah.com> References: <20170311223956.79ded6a2@andrii-VirtualBox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170311223956.79ded6a2@andrii-VirtualBox> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 11, 2017 at 10:39:56PM +0200, Andrii wrote: > Fixed code style warnings reported by checkpatch.pl script. What warning would that be? Please always be very specific. > > Signed-off-by: Andrii Vladyka Trailing whitespace on this line :( > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 6134eba..d7d2d13 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -1346,14 +1346,10 @@ hfa384x_docmd(struct hfa384x *hw, > } else if (mode == DOWAIT) { > struct usbctlx_cmd_completor completor; > > - result = > - hfa384x_usbctlx_complete_sync(hw, ctlx, > - init_cmd_completor(&completor, > - &ctlx-> > - inbuf. > - cmdresp, > - &cmd-> > - result)); > + result = hfa384x_usbctlx_complete_sync(hw, ctlx, > + init_cmd_completor(&completor, > + &ctlx->inbuf.cmdresp, > + &cmd->result)); It's still a pain to read, can't there be a better way to rewite the code to be readable? thanks, greg k-h