From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934012AbdCLPEt (ORCPT ); Sun, 12 Mar 2017 11:04:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49540 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755742AbdCLPEm (ORCPT ); Sun, 12 Mar 2017 11:04:42 -0400 Date: Sun, 12 Mar 2017 16:04:21 +0100 From: Greg KH To: SIMRAN SINGHAL Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: android: Replace strcpy with strlcpy Message-ID: <20170312150421.GA24990@kroah.com> References: <20170311220244.GA21700@singhal-Inspiron-5558> <20170312133457.GA27791@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 12, 2017 at 08:25:28PM +0530, SIMRAN SINGHAL wrote: > On Sun, Mar 12, 2017 at 7:04 PM, Greg KH wrote: > > On Sun, Mar 12, 2017 at 03:32:44AM +0530, simran singhal wrote: > >> Replace strcpy with strlcpy as strcpy does not check for buffer > >> overflow. > > > > Can there be a buffer overflow here? If not, then strcpy is just fine > > to use. Do you see a potential code path here that actually is a > > problem using this? > > > >> This is found using Flawfinder. > > > > You mean 'grep'? :) > > > > If not, what exactly does "Flawfinder" point out is wrong with the code > > here? At first glance, I can't find it, but perhaps the tool, and your > > audit, provided more information? > > > > thanks, > > > > Flawfinder reports possible security weaknesses (“flaws”) sorted by risk level. > The risk level is shown inside square brackets and varies from 0, very > little risk, > to 5, great risk. > > So, here in this case I was getting risk of [4]. > This is what I got: > drivers/staging/android/ashmem.c:551: [4] (buffer) strcpy: > Does not check for buffer overflows when copying to destination (CWE-120). > Consider using strcpy_s, strncpy, or strlcpy (warning, strncpy is easily > misused). Consider looking at the code to see if it actually is incorrect before blindly accepting random comments by a random tool :) Again, if you can see how this is incorrect, great, let's fix it, otherwise please leave it as-is because so far your fixes are actually breaking things :( thanks, greg k-h