From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934300AbdCLPxr (ORCPT <rfc822;w@1wt.eu>);
        Sun, 12 Mar 2017 11:53:47 -0400
Received: from fallback5.mail.ru ([94.100.181.253]:37385 "EHLO
        fallback5.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755684AbdCLPxi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 12 Mar 2017 11:53:38 -0400
Date: Sun, 12 Mar 2017 17:47:33 +0200
From: Andrii <tulup@mail.ru>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, sergio.paracuellos@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] staging: wlan-ng: fix avoid multiple line dereference
 warning reported by checkpatch.pl
Message-ID: <20170312174733.455782d3@andrii-VirtualBox>
In-Reply-To: <20170312154207.GB28359@kroah.com>
References: <20170311223956.79ded6a2@andrii-VirtualBox>
        <20170312173009.7d0fc710@andrii-VirtualBox>
        <20170312154207.GB28359@kroah.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Authentication-Results: smtp39.i.mail.ru; auth=pass smtp.auth=tulup@mail.ru smtp.mailfrom=tulup@mail.ru
X-7FA49CB5: 0D63561A33F958A5DAD5E19BF41C3ACEE03B49617FE1CF0F92F61AD6A3B9A8E29F18ECD7E95F35E929AFE063DF4C541C810130316441E26EDC70E24C950402A70BF2EBBBDD9D6B0F7FFC5772FDE91EBA
X-Mailru-Sender: D38F56F98757BC8FB105F8D150510D61963D26865F454FA3BADCBDC60E640464BD8BF51E7B9807170FA16B6DF5BCED823DDE9B364B0DF289F545B6422311D2D462A8EE11BCB8D19CAE208404248635DF
X-Mras: OK
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 12 Mar 2017 16:42:07 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sun, Mar 12, 2017 at 05:30:09PM +0200, Andrii wrote:
> > Fixed three code style warnings (multiple line dereference) reported
> > by checkpatch.pl script.
> > 
> > Signed-off-by: Andrii Vladyka <tulup@mail.ru>  
> 
> > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> > b/drivers/staging/wlan-ng/hfa384x_usb.c index 6134eba..a050748
> > 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> > @@ -1346,14 +1346,8 @@ hfa384x_docmd(struct hfa384x *hw,
> >  	} else if (mode == DOWAIT) {
> >  		struct usbctlx_cmd_completor completor;
> >  
> > -		result =
> > -		    hfa384x_usbctlx_complete_sync(hw, ctlx,
> > -
> > init_cmd_completor(&completor,
> > -
> > &ctlx->
> > -
> > inbuf.
> > -
> > cmdresp,
> > -
> > &cmd->
> > -
> > result));
> > +		result = hfa384x_usbctlx_complete_sync(hw, ctlx,
> > +	init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> > &cmd->result))  
> 
> Hm, did you run your patch through checkpatch?  There's no way that
> his code is correct :(
> 
> greg k-h

Yes, I did. The code is correct. Checkpatch now reports "Alignment
should match open parenthesis" CHECK, which is obviously better than
original WARNING.

Regards,
Andrii