From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Radosław Pietrzyk" <radoslaw.pietrzyk@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt
Date: Mon, 13 Mar 2017 14:19:28 +0300 [thread overview]
Message-ID: <20170313111928.GC4187@mwanda> (raw)
In-Reply-To: <CAFvLkMQJDHnwjqsB5+RCJc4HT81n4JmgoPtQ5UkAE7oG5zf+fw@mail.gmail.com>
On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote:
> Ok I will. I just have thought that in general it might be helpful to
> have this possibility as DT is parsed for this option anyway. If you
> think it is not needed at all that why to bother parsing DT for this
> option in the first place ?
I'm not saying it's a wrong patch, I just think the patch description
doesn't explain why you are doing it or the user visible effects of the
change.
regards,
dan carpenter
next prev parent reply other threads:[~2017-03-13 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 9:25 [PATCH] Allows setting bpp from dt Radoslaw Pietrzyk
2017-03-10 9:25 ` [PATCH] staging: fbtft: Allows bpp to be set " Radoslaw Pietrzyk
2017-03-12 14:27 ` Greg KH
2017-03-12 22:12 ` kbuild test robot
2017-03-13 10:28 ` [PATCH v2] " Radoslaw Pietrzyk
2017-03-13 11:00 ` Dan Carpenter
2017-03-13 11:07 ` Radosław Pietrzyk
2017-03-13 11:11 ` Dan Carpenter
2017-03-13 11:16 ` Radosław Pietrzyk
2017-03-13 11:19 ` Dan Carpenter [this message]
2017-03-13 11:21 ` Radosław Pietrzyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313111928.GC4187@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radoslaw.pietrzyk@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).