* [PATCH] isdn/gigaset: fix NULL-deref at probe
@ 2017-03-13 12:39 Johan Hovold
2017-03-13 19:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2017-03-13 12:39 UTC (permalink / raw)
To: Karsten Keil
Cc: Paul Bolle, gigaset307x-common, netdev, linux-usb, linux-kernel,
Johan Hovold, stable, Hansjoerg Lipp
Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.
Fixes: cf7776dc05b8 ("[PATCH] isdn4linux: Siemens Gigaset drivers -
direct USB connection")
Cc: stable <stable@vger.kernel.org> # 2.6.17
Cc: Hansjoerg Lipp <hjlipp@web.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/isdn/gigaset/bas-gigaset.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
index 11e13c56126f..2da3ff650e1d 100644
--- a/drivers/isdn/gigaset/bas-gigaset.c
+++ b/drivers/isdn/gigaset/bas-gigaset.c
@@ -2317,6 +2317,9 @@ static int gigaset_probe(struct usb_interface *interface,
return -ENODEV;
}
+ if (hostif->desc.bNumEndpoints < 1)
+ return -ENODEV;
+
dev_info(&udev->dev,
"%s: Device matched (Vendor: 0x%x, Product: 0x%x)\n",
__func__, le16_to_cpu(udev->descriptor.idVendor),
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] isdn/gigaset: fix NULL-deref at probe
2017-03-13 12:39 [PATCH] isdn/gigaset: fix NULL-deref at probe Johan Hovold
@ 2017-03-13 19:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-03-13 19:28 UTC (permalink / raw)
To: johan
Cc: isdn, pebolle, gigaset307x-common, netdev, linux-usb,
linux-kernel, stable, hjlipp
From: Johan Hovold <johan@kernel.org>
Date: Mon, 13 Mar 2017 13:39:01 +0100
> Make sure to check the number of endpoints to avoid dereferencing a
> NULL-pointer should a malicious device lack endpoints.
>
> Fixes: cf7776dc05b8 ("[PATCH] isdn4linux: Siemens Gigaset drivers -
> direct USB connection")
> Cc: stable <stable@vger.kernel.org> # 2.6.17
> Cc: Hansjoerg Lipp <hjlipp@web.de>
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-13 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-13 12:39 [PATCH] isdn/gigaset: fix NULL-deref at probe Johan Hovold
2017-03-13 19:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox