From: Andrew Lunn <andrew@lunn.ch>
To: "Li, Meng" <Meng.Li@windriver.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM family version
Date: Mon, 13 Mar 2017 15:31:57 +0100 [thread overview]
Message-ID: <20170313143157.GE748@lunn.ch> (raw)
In-Reply-To: <529F9A9100AE8045A7A5B5A00A39FBB83DE9325F@ALA-MBC.corp.ad.wrs.com>
On Mon, Mar 13, 2017 at 12:54:24PM +0000, Li, Meng wrote:
>
>
> > -----Original Message-----
> > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com]
> > Sent: Monday, March 13, 2017 7:54 PM
> > To: Li, Meng
> > Cc: linux-kernel@vger.kernel.org; peterhuewe@gmx.de;
> > tpmdd@selhorst.net; jgunthorpe@obsidianresearch.com; tpmdd-
> > devel@lists.sourceforge.net
> > Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM family version
> >
> > On Mon, Mar 13, 2017 at 05:20:17PM +0800, Meng.Li@windriver.com wrote:
> > > From: Limeng <Meng.Li@windriver.com>
> > >
> > > So far, there is not a sysfs interface for user space code to check
> > > the TPM family version(TPM1.x or TPM2). So, add a file named
> > > description in /sys/class/tpm/tpmX/ to show it.
> > >
> > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > ---
> >
> > Is this the first or which version of the patch is this? Version number and
> > changelog are missing :/
>
> Hi Jarkko,
>
> This is the second version of this patch. The first one is reviewed by Peter who give out some good advices.
>
> It is my first time to submit patch to upstream(main line),
A tip for you then. Wait at least one day between patch versions. That
gives people time to comment on your patches, and you can fix many
different issues at once.
> and I am not very clear with the submitting rule.
A good start is:
Documentation/process/submitting-patches.rst
> So, could you please give me a template to record the version and changing log?
After the --- write one line per change you made from the previous
version. Also, v3 should also contain the v2 change history etc...
Picking a random example from the web:
http://patchwork.ozlabs.org/patch/710615/
Andrew
next prev parent reply other threads:[~2017-03-13 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 9:20 [PATCH] tpm: Add sysfs interface to show TPM family version Meng.Li
2017-03-13 11:54 ` Jarkko Sakkinen
2017-03-13 12:54 ` Li, Meng
2017-03-13 14:31 ` Andrew Lunn [this message]
2017-03-13 14:59 ` Jarkko Sakkinen
2017-03-13 16:55 ` Jason Gunthorpe
2017-03-13 18:35 ` Jarkko Sakkinen
2017-03-13 18:46 ` [tpmdd-devel] " James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313143157.GE748@lunn.ch \
--to=andrew@lunn.ch \
--cc=Meng.Li@windriver.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox