From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: changbin.du@intel.com
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, Feng Tang <feng.tang@intel.com>
Subject: Re: [PATCH] perf: fix typo in function switch_data_file
Date: Mon, 13 Mar 2017 12:00:04 -0300 [thread overview]
Message-ID: <20170313150004.GQ2750@kernel.org> (raw)
In-Reply-To: <20170313114652.9207-1-changbin.du@intel.com>
Em Mon, Mar 13, 2017 at 07:46:52PM +0800, changbin.du@intel.com escreveu:
> From: Changbin Du <changbin.du@intel.com>
>
> Should clear buf abs_path, not options.
Thanks, applied.
- Arnaldo
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
> tools/perf/ui/browsers/hists.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index a6dae80..6fafe02 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -2350,7 +2350,7 @@ static int switch_data_file(void)
> return ret;
>
> memset(options, 0, sizeof(options));
> - memset(options, 0, sizeof(abs_path));
> + memset(abs_path, 0, sizeof(abs_path));
>
> while ((dent = readdir(pwd_dir))) {
> char path[PATH_MAX];
> --
> 2.7.4
next prev parent reply other threads:[~2017-03-13 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 11:46 [PATCH] perf: fix typo in function switch_data_file changbin.du
2017-03-13 15:00 ` Arnaldo Carvalho de Melo [this message]
2017-03-15 18:38 ` [tip:perf/core] perf hists browser: Fix " tip-bot for Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313150004.GQ2750@kernel.org \
--to=acme@kernel.org \
--cc=changbin.du@intel.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox