* [PATCH] perf: fix typo in function switch_data_file
@ 2017-03-13 11:46 changbin.du
2017-03-13 15:00 ` Arnaldo Carvalho de Melo
2017-03-15 18:38 ` [tip:perf/core] perf hists browser: Fix " tip-bot for Changbin Du
0 siblings, 2 replies; 3+ messages in thread
From: changbin.du @ 2017-03-13 11:46 UTC (permalink / raw)
To: peterz, mingo, acme; +Cc: linux-kernel, Changbin Du
From: Changbin Du <changbin.du@intel.com>
Should clear buf abs_path, not options.
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
tools/perf/ui/browsers/hists.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index a6dae80..6fafe02 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2350,7 +2350,7 @@ static int switch_data_file(void)
return ret;
memset(options, 0, sizeof(options));
- memset(options, 0, sizeof(abs_path));
+ memset(abs_path, 0, sizeof(abs_path));
while ((dent = readdir(pwd_dir))) {
char path[PATH_MAX];
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf: fix typo in function switch_data_file
2017-03-13 11:46 [PATCH] perf: fix typo in function switch_data_file changbin.du
@ 2017-03-13 15:00 ` Arnaldo Carvalho de Melo
2017-03-15 18:38 ` [tip:perf/core] perf hists browser: Fix " tip-bot for Changbin Du
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-03-13 15:00 UTC (permalink / raw)
To: changbin.du; +Cc: peterz, mingo, linux-kernel, Feng Tang
Em Mon, Mar 13, 2017 at 07:46:52PM +0800, changbin.du@intel.com escreveu:
> From: Changbin Du <changbin.du@intel.com>
>
> Should clear buf abs_path, not options.
Thanks, applied.
- Arnaldo
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
> tools/perf/ui/browsers/hists.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index a6dae80..6fafe02 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -2350,7 +2350,7 @@ static int switch_data_file(void)
> return ret;
>
> memset(options, 0, sizeof(options));
> - memset(options, 0, sizeof(abs_path));
> + memset(abs_path, 0, sizeof(abs_path));
>
> while ((dent = readdir(pwd_dir))) {
> char path[PATH_MAX];
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:perf/core] perf hists browser: Fix typo in function switch_data_file
2017-03-13 11:46 [PATCH] perf: fix typo in function switch_data_file changbin.du
2017-03-13 15:00 ` Arnaldo Carvalho de Melo
@ 2017-03-15 18:38 ` tip-bot for Changbin Du
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Changbin Du @ 2017-03-15 18:38 UTC (permalink / raw)
To: linux-tip-commits
Cc: feng.tang, changbin.du, mingo, acme, tglx, linux-kernel, hpa,
peterz
Commit-ID: 3ef5b4023c64c16c793a066a7a2ed6ea3767e0d7
Gitweb: http://git.kernel.org/tip/3ef5b4023c64c16c793a066a7a2ed6ea3767e0d7
Author: Changbin Du <changbin.du@intel.com>
AuthorDate: Mon, 13 Mar 2017 19:46:52 +0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 13 Mar 2017 11:58:57 -0300
perf hists browser: Fix typo in function switch_data_file
Should clear buf 'abs_path', not 'options'.
Signed-off-by: Changbin Du <changbin.du@intel.com>
Cc: Feng Tang <feng.tang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 341487ab561f ("perf hists browser: Add option for runtime switching perf data file")
Link: http://lkml.kernel.org/r/20170313114652.9207-1-changbin.du@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/browsers/hists.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index fc4fb66..2dc82be 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2308,7 +2308,7 @@ static int switch_data_file(void)
return ret;
memset(options, 0, sizeof(options));
- memset(options, 0, sizeof(abs_path));
+ memset(abs_path, 0, sizeof(abs_path));
while ((dent = readdir(pwd_dir))) {
char path[PATH_MAX];
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-15 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-13 11:46 [PATCH] perf: fix typo in function switch_data_file changbin.du
2017-03-13 15:00 ` Arnaldo Carvalho de Melo
2017-03-15 18:38 ` [tip:perf/core] perf hists browser: Fix " tip-bot for Changbin Du
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox