linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>, Mark Brown <broonie@kernel.org>,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 06/12] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk
Date: Tue, 14 Mar 2017 09:40:13 +0530	[thread overview]
Message-ID: <20170314041013.GB2843@localhost> (raw)
In-Reply-To: <20170305133709.6288-7-icenowy@aosc.xyz>

On Sun, Mar 05, 2017 at 09:37:03PM +0800, Icenowy Zheng wrote:
> Originally we enable a special gate bit when the compatible indicates
> A23/33.
> 
> But according to BSP sources and user manuals, more SoCs will need this
> gate bit.
> 
> So make it a common quirk configured in the config struct.
> 
> The BSP source also indicates that A83T will need this gate bit (there's
> "SUN8IW6" in the #ifdef's), so also enable this gate bit for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  drivers/dma/sun6i-dma.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> index a2358780ab2c..889fb24023cd 100644
> --- a/drivers/dma/sun6i-dma.c
> +++ b/drivers/dma/sun6i-dma.c
> @@ -101,6 +101,7 @@ struct sun6i_dma_config {
>  	u32 nr_max_channels;
>  	u32 nr_max_requests;
>  	u32 nr_max_vchans;
> +	bool gate_needed;

can you please explain what gate means here

-- 
~Vinod

      parent reply	other threads:[~2017-03-14  4:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170305133709.6288-1-icenowy@aosc.xyz>
     [not found] ` <20170305133709.6288-2-icenowy@aosc.xyz>
2017-03-06  3:43   ` [linux-sunxi] [PATCH v2 01/12] ASoC: sun8i-codec-analog: split out mic2 Chen-Yu Tsai
2017-03-15 18:13   ` Applied "ASoC: sun8i-codec-analog: split out mic2" to the asoc tree Mark Brown
     [not found] ` <20170305133709.6288-3-icenowy@aosc.xyz>
2017-03-06  3:45   ` [linux-sunxi] [PATCH v2 02/12] ASoC: sun8i-codec-analog: split out line in Chen-Yu Tsai
2017-03-15 18:13   ` Applied "ASoC: sun8i-codec-analog: split out line in" to the asoc tree Mark Brown
     [not found] ` <20170305133709.6288-5-icenowy@aosc.xyz>
2017-03-06  3:53   ` [linux-sunxi] [PATCH v2 04/12] ASoC: sun8i-codec-analog: add support for V3s SoC Chen-Yu Tsai
     [not found] ` <20170305133709.6288-8-icenowy@aosc.xyz>
2017-03-06  3:58   ` [linux-sunxi] [PATCH v2 07/12] dmaengine: sun6i: support V3s SoC variant Chen-Yu Tsai
     [not found] ` <20170305133709.6288-6-icenowy@aosc.xyz>
2017-03-06  4:05   ` [linux-sunxi] [PATCH v2 05/12] ASoC: sun4i-codec: Add support for V3s codec Chen-Yu Tsai
2017-03-06  4:15     ` Chen-Yu Tsai
     [not found] ` <20170305133709.6288-9-icenowy@aosc.xyz>
2017-03-06  4:12   ` [linux-sunxi] [PATCH v2 08/12] ARM: dts: sun8i: restore the inclusion of ccu headers in V3s DTSI Chen-Yu Tsai
     [not found] ` <20170305133709.6288-10-icenowy@aosc.xyz>
2017-03-06  4:13   ` [linux-sunxi] [PATCH v2 09/12] ARM: dts: sun8i: add DMA engine " Chen-Yu Tsai
     [not found] ` <20170305133709.6288-11-icenowy@aosc.xyz>
2017-03-06  4:17   ` [PATCH v2 10/12] ARM: dts: sun8i: add audio codec support into " Chen-Yu Tsai
     [not found] ` <20170305133709.6288-12-icenowy@aosc.xyz>
2017-03-06  4:22   ` [linux-sunxi] [PATCH v2 11/12] ARM: dts: sun8i: add pinmux for V3s mmc1 Chen-Yu Tsai
     [not found] ` <20170305133709.6288-13-icenowy@aosc.xyz>
2017-03-06  4:28   ` [linux-sunxi] [PATCH v2 12/12] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock Chen-Yu Tsai
     [not found] ` <20170305133709.6288-4-icenowy@aosc.xyz>
     [not found]   ` <6803451488721799@web16g.yandex.ru>
2017-03-06  3:46     ` [linux-sunxi] Re: [PATCH v2 03/12] ASoC: sun8i-codec-analog: split out mbias Chen-Yu Tsai
2017-03-07  0:15   ` [alsa-devel] " kbuild test robot
2017-03-07  8:57 ` [PATCH v2 00/12] Add support for the audio codec on Allwinner V3s Vinod Koul
     [not found] ` <20170305133709.6288-7-icenowy@aosc.xyz>
2017-03-06  3:50   ` [PATCH v2 06/12] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk Chen-Yu Tsai
2017-03-14  4:10   ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314041013.GB2843@localhost \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=icenowy@aosc.xyz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).