From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750997AbdCNEJM (ORCPT ); Tue, 14 Mar 2017 00:09:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:40416 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbdCNEJK (ORCPT ); Tue, 14 Mar 2017 00:09:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,162,1486454400"; d="scan'208";a="834284682" Date: Tue, 14 Mar 2017 09:40:13 +0530 From: Vinod Koul To: Icenowy Zheng Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Mark Brown , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 06/12] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk Message-ID: <20170314041013.GB2843@localhost> References: <20170305133709.6288-1-icenowy@aosc.xyz> <20170305133709.6288-7-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170305133709.6288-7-icenowy@aosc.xyz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 05, 2017 at 09:37:03PM +0800, Icenowy Zheng wrote: > Originally we enable a special gate bit when the compatible indicates > A23/33. > > But according to BSP sources and user manuals, more SoCs will need this > gate bit. > > So make it a common quirk configured in the config struct. > > The BSP source also indicates that A83T will need this gate bit (there's > "SUN8IW6" in the #ifdef's), so also enable this gate bit for it. > > Signed-off-by: Icenowy Zheng > --- > drivers/dma/sun6i-dma.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index a2358780ab2c..889fb24023cd 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -101,6 +101,7 @@ struct sun6i_dma_config { > u32 nr_max_channels; > u32 nr_max_requests; > u32 nr_max_vchans; > + bool gate_needed; can you please explain what gate means here -- ~Vinod