From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751001AbdCNJkf (ORCPT ); Tue, 14 Mar 2017 05:40:35 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27633 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdCNJke (ORCPT ); Tue, 14 Mar 2017 05:40:34 -0400 Date: Tue, 14 Mar 2017 12:40:12 +0300 From: Dan Carpenter To: mshan Cc: gregkh@linuxfoundation.org, domdevlin@free.fr, bhumirks@gmail.com, chopin.simon@gmail.com, mohsinshan1k@gmail.com, peter@hurleysoftware.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues. Message-ID: <20170314094011.GM4136@mwanda> References: <1489467134-6455-1-git-send-email-mohsinshan1k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489467134-6455-1-git-send-email-mohsinshan1k@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2017 at 09:52:14PM -0700, mshan wrote: > Signed-off-by: mshan > --- > drivers/staging/fwserial/fwserial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c > index 41a49c8..d693c03 100644 > --- a/drivers/staging/fwserial/fwserial.c > +++ b/drivers/staging/fwserial/fwserial.c > @@ -98,7 +98,7 @@ struct fwtty_transaction { > }; > }; > > -#define to_device(a, b) (a->b) > +#define to_device(a, b) ((a)->(b)) This macro is silly. Just delete it. regards, dan carpenter