From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750851AbdCNJo3 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Mar 2017 05:44:29 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:29956 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750744AbdCNJo2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Mar 2017 05:44:28 -0400
Date: Tue, 14 Mar 2017 12:43:47 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Wolfram Sang <wsa@the-dreams.de>,
        sayli karnik <karniksayli1995@gmail.com>,
        Markus Elfring <elfring@users.sourceforge.net>,
        Nick Rosbrook <nrosbrook@mail.smcvt.edu>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ks7010: adding parenthesis to macro argument
Message-ID: <20170314094347.GN4136@mwanda>
References: <1489470162-39598-1-git-send-email-pushkar.iit@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1489470162-39598-1-git-send-email-pushkar.iit@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wrote:
> Description:
> In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis around macro params.
> Also, removing extra line.

Don't do this as one patch.

> 
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index a604c83..644b8d4 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);
>  /* macro */
>  
>  #define inc_txqhead(priv) \
> -	(priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
> +	((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)

I can't get excited about this at all.  Make it a function or leave it
alone.

regards,
dan carpenter