From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750919AbdCNKmT (ORCPT ); Tue, 14 Mar 2017 06:42:19 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37296 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdCNKmS (ORCPT ); Tue, 14 Mar 2017 06:42:18 -0400 Date: Tue, 14 Mar 2017 13:41:51 +0300 From: Dan Carpenter To: Pushkar Jambhlekar Cc: Greg Kroah-Hartman , Wolfram Sang , sayli karnik , Markus Elfring , Nick Rosbrook , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ks7010: adding parenthesis to macro argument Message-ID: <20170314104151.GE4187@mwanda> References: <1489470162-39598-1-git-send-email-pushkar.iit@gmail.com> <20170314094347.GN4136@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2017 at 03:01:50AM -0700, Pushkar Jambhlekar wrote: > Hi Dan, > > I am trying to fix warnings by "checkpatch.pl". Even though it is not > super exciting, no harm to follow correct way. > The harm is that it takes something that's already terrible and makes it even more unreadable. regards, dan carpenter