From: Andrew Lunn <andrew@lunn.ch>
To: Matthias May <matthias.may@neratec.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Jason Cobham <jcobham@questertangent.com>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time
Date: Tue, 14 Mar 2017 13:05:39 +0100 [thread overview]
Message-ID: <20170314120539.GT15842@lunn.ch> (raw)
In-Reply-To: <535be006-e384-aca3-ee8b-4ed36b66b97a@neratec.com>
> Hi
> The never ever seeing R/W failure on MDIO bus is not exactly accurate.
> We had with art (atheros calibration tool) the problem that interrupts
> were being disabled which lead to MDIO operations running into
> timout/failing.
Yes, i've seen similar with power management bugs for the MDIO
driver. But you get a cascade of failures, lots of warnings and error
prints, it is clear something bad has happened, and the switch is in
an inconsistent state. So having one more debug print which is also
inconsistent does no really harm.
Anyway, this whole conversation has taken more effort than just making
this simple change to remove a few lines of code. So lets drop it and
move on.
Andrew
next prev parent reply other threads:[~2017-03-14 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 19:20 [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Vivien Didelot
2017-03-13 22:39 ` Andrew Lunn
2017-03-13 22:42 ` Florian Fainelli
2017-03-13 22:58 ` Andrew Lunn
2017-03-14 11:12 ` Matthias May
2017-03-14 12:05 ` Andrew Lunn [this message]
2017-03-14 13:56 ` Vivien Didelot
2017-03-14 14:18 ` Andrew Lunn
2017-03-28 18:13 ` Vivien Didelot
2017-03-29 4:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314120539.GT15842@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jcobham@questertangent.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.may@neratec.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox