From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752453AbdCNNbd (ORCPT ); Tue, 14 Mar 2017 09:31:33 -0400 Received: from mail.kernel.org ([198.145.29.136]:57068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbdCNNbE (ORCPT ); Tue, 14 Mar 2017 09:31:04 -0400 Date: Tue, 14 Mar 2017 10:30:56 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Kefeng Wang , linux-kernel@vger.kernel.org, Peter Zijlstra , Jiri Olsa , Namhyung Kim , Wang Nan , guohanjun@huawei.com Subject: Re: [PATCH] perf probe: Return errno when does not hit any event Message-ID: <20170314133056.GE3089@kernel.org> References: <1488792891-57629-1-git-send-email-wangkefeng.wang@huawei.com> <326abd0a-1dd5-0cf0-245a-78c3b7802515@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: > Hi all, any comments, thanks. For 'perf probe' make sure Masami is in the CC list, adding him, Masami? - Arnaldo > On 2017/3/7 15:33, Kefeng Wang wrote: > > + Arnaldo Carvalho de Melo > > > > On 2017/3/6 17:34, Kefeng Wang wrote: > >> On old perf, when using perf probe -d to delete an inexistent event, > >> it return errno, eg, > >> > >> -bash-4.3# perf probe -d xxx || echo $? > >> Info: Event "*:xxx" does not exist. > >> Error: Failed to delete events. > >> 255 > >> > >> But now perf_del_probe_events() will always set ret = 0, different > >> from previous del_perf_probe_events(). After this, it return errno > >> again, eg, > >> > >> -bash-4.3# ./perf probe -d xxx || echo $? > >> Error: Failed to delete events. > >> 254 > >> > >> And it is more appropriate to return -ENOENT instead of -EPERM. > >> > >> Signed-off-by: Kefeng Wang > >> --- > >> tools/perf/builtin-probe.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c > >> index 1fcebc3..c46b41c 100644 > >> --- a/tools/perf/builtin-probe.c > >> +++ b/tools/perf/builtin-probe.c > >> @@ -444,7 +444,8 @@ static int perf_del_probe_events(struct strfilter *filter) > >> if (ret == -ENOENT && ret2 == -ENOENT) > >> pr_debug("\"%s\" does not hit any event.\n", str); > >> /* Note that this is silently ignored */ > >> - ret = 0; > >> + else > >> + ret = 0; > >> > >> error: > >> if (kfd >= 0) > >> > > > > > > . > >