From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753206AbdCNPAi (ORCPT ); Tue, 14 Mar 2017 11:00:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49430 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbdCNO44 (ORCPT ); Tue, 14 Mar 2017 10:56:56 -0400 Date: Tue, 14 Mar 2017 15:56:43 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 01/13] perf, tools, stat: Factor out callback for collecting event values Message-ID: <20170314145643.GA28151@krava> References: <20170310212446.6662-1-andi@firstfloor.org> <20170310212446.6662-2-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170310212446.6662-2-andi@firstfloor.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 14 Mar 2017 14:56:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 10, 2017 at 01:24:34PM -0800, Andi Kleen wrote: SNIP > + > +struct aggr_data { > + u64 ena, run, val; > + int id; > + int nr; > + int cpu; > +}; > + > +static void aggr_cb(struct perf_evsel *counter, void *data, bool first) > +{ > + struct aggr_data *ad = data; > + int cpu, s2; > + > + for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) { > + struct perf_counts_values *counts; > + > + s2 = aggr_get_id(evsel_list->cpus, cpu); why do use evsel_list instead of perf_evsel__cpus(counter), which is in the original/removed code? this patch is about adding collect_data.. if you want to choose this part, please make it clear in separate patch thanks, jirka