* [PATCH] KVM: nVMX: don't reset kvm mmu twice
@ 2017-03-12 8:53 Wanpeng Li
2017-03-13 8:37 ` David Hildenbrand
2017-03-14 20:39 ` Radim Krčmář
0 siblings, 2 replies; 3+ messages in thread
From: Wanpeng Li @ 2017-03-12 8:53 UTC (permalink / raw)
To: linux-kernel, kvm; +Cc: Paolo Bonzini, Radim Krčmář, Wanpeng Li
From: Wanpeng Li <wanpeng.li@hotmail.com>
kvm mmu is reset once successfully loading CR3 as part of emulating vmentry
in nested_vmx_load_cr3(). We should not reset kvm mmu twice.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
---
arch/x86/kvm/vmx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 98e82ee..bca8d7a 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -10286,8 +10286,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
entry_failure_code))
return 1;
- kvm_mmu_reset_context(vcpu);
-
if (!enable_ept)
vcpu->arch.walk_mmu->inject_page_fault = vmx_inject_page_fault_nested;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: nVMX: don't reset kvm mmu twice
2017-03-12 8:53 [PATCH] KVM: nVMX: don't reset kvm mmu twice Wanpeng Li
@ 2017-03-13 8:37 ` David Hildenbrand
2017-03-14 20:39 ` Radim Krčmář
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2017-03-13 8:37 UTC (permalink / raw)
To: Wanpeng Li, linux-kernel, kvm
Cc: Paolo Bonzini, Radim Krčmář, Wanpeng Li
Am 12.03.2017 um 09:53 schrieb Wanpeng Li:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> kvm mmu is reset once successfully loading CR3 as part of emulating vmentry
> in nested_vmx_load_cr3(). We should not reset kvm mmu twice.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
> arch/x86/kvm/vmx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 98e82ee..bca8d7a 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -10286,8 +10286,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
> entry_failure_code))
> return 1;
>
> - kvm_mmu_reset_context(vcpu);
> -
> if (!enable_ept)
> vcpu->arch.walk_mmu->inject_page_fault = vmx_inject_page_fault_nested;
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: nVMX: don't reset kvm mmu twice
2017-03-12 8:53 [PATCH] KVM: nVMX: don't reset kvm mmu twice Wanpeng Li
2017-03-13 8:37 ` David Hildenbrand
@ 2017-03-14 20:39 ` Radim Krčmář
1 sibling, 0 replies; 3+ messages in thread
From: Radim Krčmář @ 2017-03-14 20:39 UTC (permalink / raw)
To: Wanpeng Li; +Cc: linux-kernel, kvm, Paolo Bonzini, Wanpeng Li
2017-03-12 00:53-0800, Wanpeng Li:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> kvm mmu is reset once successfully loading CR3 as part of emulating vmentry
> in nested_vmx_load_cr3(). We should not reset kvm mmu twice.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
Queued, thanks.
> arch/x86/kvm/vmx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 98e82ee..bca8d7a 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -10286,8 +10286,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
> entry_failure_code))
> return 1;
>
> - kvm_mmu_reset_context(vcpu);
> -
> if (!enable_ept)
> vcpu->arch.walk_mmu->inject_page_fault = vmx_inject_page_fault_nested;
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-14 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-12 8:53 [PATCH] KVM: nVMX: don't reset kvm mmu twice Wanpeng Li
2017-03-13 8:37 ` David Hildenbrand
2017-03-14 20:39 ` Radim Krčmář
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox