From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: "Stephen Warren" <swarren@wwwdotorg.org>,
"Lee Jones" <lee@kernel.org>, "Eric Anholt" <eric@anholt.net>,
"Michael Zoran" <mzoran@crowfest.net>,
"Daniel Stone" <daniels@collabora.com>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Stafford Horne" <shorne@gmail.com>,
popcornmix <popcornmix@gmail.com>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vc04_services: Fixing coding and logical guidelines
Date: Wed, 15 Mar 2017 12:52:08 +0800 [thread overview]
Message-ID: <20170315045208.GA9748@kroah.com> (raw)
In-Reply-To: <1489496944-44038-1-git-send-email-pushkar.iit@gmail.com>
On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
> Description:
No need for that line.
> in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.
Why indent? Also, you need to be specific as to what type of changes
you made.
> Also, fixing logical issue, i.e. removing break after goto statement.
Don't do multiple things in the same patch, break it up into
one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one
thing" :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-03-15 4:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 13:09 [PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar
2017-03-15 4:52 ` Greg Kroah-Hartman [this message]
2017-03-15 5:02 ` Pushkar Jambhlekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315045208.GA9748@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mzoran@crowfest.net \
--cc=noralf@tronnes.org \
--cc=popcornmix@gmail.com \
--cc=pushkar.iit@gmail.com \
--cc=shorne@gmail.com \
--cc=stefan.wahren@i2se.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox