From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbdCOIiM (ORCPT ); Wed, 15 Mar 2017 04:38:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22360 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbdCOIiK (ORCPT ); Wed, 15 Mar 2017 04:38:10 -0400 Date: Wed, 15 Mar 2017 11:37:53 +0300 From: Dan Carpenter To: mshan Cc: gregkh@linuxfoundation.org, mohsinshan1k@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings. Message-ID: <20170315083753.GX4136@mwanda> References: <1489550030-24841-1-git-send-email-mohsinshan1k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489550030-24841-1-git-send-email-mohsinshan1k@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the subject. The subsystem prefix is wrong and it's too vague. Change it to: [PATCH] Staging: goldfish: use __func__ instead of embedded function names On Tue, Mar 14, 2017 at 08:53:50PM -0700, mshan wrote: > Embedded function names are less appropriate to use when > refactoring, can cause function renaming. Prefer the use > of "%s", __func__ to embedded function names > > Signed-off-by: mshan Please use your legal/formal name as if you were signing a legal document. Also change the From header on your email to match. regards, dan carpenter