From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340AbdCOKQs (ORCPT ); Wed, 15 Mar 2017 06:16:48 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32456 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbdCOKQq (ORCPT ); Wed, 15 Mar 2017 06:16:46 -0400 Date: Wed, 15 Mar 2017 13:16:28 +0300 From: Dan Carpenter To: sunil.m@techveda.org Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, karthiknishu@yahoo.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/8] staging: rtl8192e: Remove unnecessary 'out of memory' message Message-ID: <20170315101628.GA4136@mwanda> References: <20170312134112.GF27791@kroah.com> <1489571517-3332-1-git-send-email-sunil.m@techveda.org> <1489571517-3332-4-git-send-email-sunil.m@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489571517-3332-4-git-send-email-sunil.m@techveda.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 15, 2017 at 03:21:52PM +0530, sunil.m@techveda.org wrote: > From: Suniel Mahesh > > Fixed the following checkpatch.pl warning: > Possible unnecessary 'out of memory' message > > Signed-off-by: Suniel Mahesh > --- > Changes for v3: > > - Split earlier patches into multiple commits for easy review > as suggested by Greg K-H > - Modified subject and description for better readability > - Rebased on top of next-20170310 > - Patches were tested and built on next-20170310 and staging-testing > as suggested by Greg K-H, no errors reported > > Changes for v2: > > - Improve error handling reported by checkpatch.pl in rtl_core.c > - new patch addition to the series > - Rebased on top of next-20170306 > --- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > index eb2321c..37a03ca 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > @@ -971,8 +971,8 @@ static void _rtl92e_init_priv_variable(struct net_device *dev) > > priv->pFirmware = vzalloc(sizeof(struct rt_firmware)); > if (!priv->pFirmware) > - netdev_err(dev, > - "rtl8192e: Unable to allocate space for firmware\n"); > + return; The patch description doesn't mention this return. regards, dan carpenter