From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752955AbdCOKZB (ORCPT ); Wed, 15 Mar 2017 06:25:01 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:49527 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbdCOKZA (ORCPT ); Wed, 15 Mar 2017 06:25:00 -0400 Date: Wed, 15 Mar 2017 13:24:43 +0300 From: Dan Carpenter To: sunil.m@techveda.org Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, karthiknishu@yahoo.com Subject: Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces Message-ID: <20170315102443.GC10762@mwanda> References: <20170312134112.GF27791@kroah.com> <1489571517-3332-1-git-send-email-sunil.m@techveda.org> <1489571517-3332-6-git-send-email-sunil.m@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489571517-3332-6-git-send-email-sunil.m@techveda.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 15, 2017 at 03:21:54PM +0530, sunil.m@techveda.org wrote: > @@ -2294,17 +2294,20 @@ static int _rtl92e_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) > > if (ipw->cmd == IEEE_CMD_SET_ENCRYPTION) { > if (ipw->u.crypt.set_tx) { > - if (strcmp(ipw->u.crypt.alg, "CCMP") == 0) > + if (strcmp(ipw->u.crypt.alg, "CCMP") == 0) { > ieee->pairwise_key_type = KEY_TYPE_CCMP; > - else if (strcmp(ipw->u.crypt.alg, "TKIP") == 0) > + } else if (strcmp(ipw->u.crypt.alg, > + "TKIP") == 0) { This is higgledy piggledy. The original was better. regards, dan carpenter