From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbdCOGPL (ORCPT ); Wed, 15 Mar 2017 02:15:11 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:35123 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751100AbdCOGPJ (ORCPT ); Wed, 15 Mar 2017 02:15:09 -0400 Date: Wed, 15 Mar 2017 14:10:01 +0800 From: Jisheng Zhang To: Andy Shevchenko CC: Vignesh R , linux-arm Mailing List , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Jiri Slaby Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() Message-ID: <20170315141001.62c4fc67@xhacker> In-Reply-To: References: <20170308121943.29340-1-vigneshr@ti.com> <2a0cf043-6e3f-6807-0794-d9d6f46b77f5@ti.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-15_02:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703150049 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2017 17:59:01 +0200 Andy Shevchenko wrote: > On Tue, Mar 14, 2017 at 3:44 PM, Vignesh R wrote: > > On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote: > >> On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R wrote: > >>> Passing "serial" as name during request_irq() results in all serial port > >>> irqs have same name. This does not help much to easily identify which > >>> irq belongs to which serial port instance. Therefore pass dev_name() > >>> during request_irq() so that better identifiable name is listed for > >>> serial ports in cat /proc/interrupts output. > >>> > >>> Output of cat /proc/interrupts > >>> Before this patch: > >>> 26: 689 0 GICv2 309 Edge serial > >>> After this patch: > >>> 26: 696 0 GICv2 309 Edge 2530c00.serial > > > But, this change is making interrupt name more descriptive > > It doesn't in PCI case, it makes it worse. indeed, in PCI case, I see 4: ... 00:03.3 what about "dev_driver_string(up->port.dev)[dev_name(up->port.dev)]" as we did for ahci case? Thanks