From: Andi Kleen <andi@firstfloor.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: acme@kernel.org, mingo@kernel.org, jolsa@kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks
Date: Wed, 15 Mar 2017 19:22:18 -0700 [thread overview]
Message-ID: <20170316022218.GE14380@two.firstfloor.org> (raw)
In-Reply-To: <87zigmt18q.fsf@concordia.ellerman.id.au>
> > + memset(&al, 0, sizeof(al));
> > + if (end - start > MAXBB - MAXINSN) {
> > + if (last)
> > + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> > + start, end);
> > + else
> > + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",
Thanks. Should be %" PRIu64 " of course.
Arnaldo, can you do the change or should I send a patch?
-Andi
> > + start, end, end - start);
>
> This looks to be breaking the build on ppc64:
>
> builtin-script.c: In function ‘grab_bb’:
> builtin-script.c:595:11: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=]
> printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", start, end, end - start);
> ^
>
> cheers
>
next prev parent reply other threads:[~2017-03-16 2:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 23:46 [PATCH] perf, tools, script: Add brstackinsn for branch stacks Andi Kleen
2017-03-16 2:16 ` Michael Ellerman
2017-03-16 2:22 ` Andi Kleen [this message]
2017-03-16 12:25 ` Arnaldo Carvalho de Melo
2017-03-16 16:36 ` [tip:perf/core] perf script: Add 'brstackinsn' " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316022218.GE14380@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox