From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751037AbdCPCWX (ORCPT ); Wed, 15 Mar 2017 22:22:23 -0400 Received: from one.firstfloor.org ([193.170.194.197]:56829 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbdCPCWW (ORCPT ); Wed, 15 Mar 2017 22:22:22 -0400 Date: Wed, 15 Mar 2017 19:22:18 -0700 From: Andi Kleen To: Michael Ellerman Cc: acme@kernel.org, mingo@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen , Andi Kleen Subject: Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks Message-ID: <20170316022218.GE14380@two.firstfloor.org> References: <20170223234634.583-1-andi@firstfloor.org> <87zigmt18q.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zigmt18q.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + memset(&al, 0, sizeof(al)); > > + if (end - start > MAXBB - MAXINSN) { > > + if (last) > > + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n", > > + start, end); > > + else > > + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", Thanks. Should be %" PRIu64 " of course. Arnaldo, can you do the change or should I send a patch? -Andi > > + start, end, end - start); > > This looks to be breaking the build on ppc64: > > builtin-script.c: In function ‘grab_bb’: > builtin-script.c:595:11: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=] > printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", start, end, end - start); > ^ > > cheers >