From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbdCPFd1 (ORCPT ); Thu, 16 Mar 2017 01:33:27 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:36149 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbdCPFdZ (ORCPT ); Thu, 16 Mar 2017 01:33:25 -0400 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 16 Mar 2017 14:33:13 +0900 From: Minchan Kim To: Sergey Senozhatsky , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@lge.com, Johannes Weiner , Michal Hocko , "Kirill A. Shutemov" , Anshuman Khandual Subject: Re: [PATCH v2 10/10] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Message-ID: <20170316053313.GA19241@bbox> References: <1489555493-14659-1-git-send-email-minchan@kernel.org> <1489555493-14659-11-git-send-email-minchan@kernel.org> <20170316044023.GA2597@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170316044023.GA2597@jagdpanzerIV.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Sergey, On Thu, Mar 16, 2017 at 01:40:23PM +0900, Sergey Senozhatsky wrote: > Hello, > > > On (03/15/17 14:24), Minchan Kim wrote: > > There is no user for it. Remove it. > > > > there is one. > > mm/rmap.c > > try_to_unmap_one() > ... > if (unlikely(PageSwapBacked(page) != PageSwapCache(page))) { > WARN_ON_ONCE(1); > ret = SWAP_FAIL; > page_vma_mapped_walk_done(&pvmw); > break; > } "There is no user for it" I was liar so need to be a honest guy. Thanks, Sergey! Andrew, Please make me honest. Sorry about that. >>From 286eae763d145338dc6c437258a741f293fab609 Mon Sep 17 00:00:00 2001 From: Minchan Kim Date: Thu, 16 Mar 2017 14:20:42 +0900 Subject: [PATCH] mm: use false instead of SWAP_FAIL There was mistake with git-rebase. SWAP_FAIL was removed. Use false. It could be folded into mm-make-ttus-return-boolean.patch. Reported-by: Sergey Senozhatsky Signed-off-by: Minchan Kim --- mm/rmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/rmap.c b/mm/rmap.c index aa25fde..2422758 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1414,7 +1414,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma, */ if (unlikely(PageSwapBacked(page) != PageSwapCache(page))) { WARN_ON_ONCE(1); - ret = SWAP_FAIL; + ret = false; page_vma_mapped_walk_done(&pvmw); break; } -- 2.7.4