From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751490AbdCPHCK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 03:02:10 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:54218 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751118AbdCPHCJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 03:02:09 -0400
Date: Thu, 16 Mar 2017 16:01:54 +0900
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        Kirk Reiser <kirk@reisers.ca>, speakup@linux-speakup.org,
        Chris Brannon <chris@the-brannons.com>
Subject: Re: [patch 4/4] staging: speakup: move those functions which do
 outgoing serial comms, into serialio.c
Message-ID: <20170316070154.GA24362@kroah.com>
References: <20170314134151.603195427@gmail.com>
 <20170314134523.466213093@gmail.com>
 <20170316021409.GA26547@kroah.com>
 <20170316065154.GA756@sanghar>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170316065154.GA756@sanghar>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 16, 2017 at 06:51:54AM +0000, Okash Khawaja wrote:
> On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote:
> > On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote:
> > > This moves spk_synth_immediate and spk_serial_synth_probe functions into
> > > serialio.c. These functions do outgoing serial comms. The move is a step
> > > towards collecting all serial comms in serialio.c. This also renames
> > > spk_synth_immediate to spk_serial_synth_immediate.
> > > 
> > > Code inside those functions has not been changed. Along the way, this patch
> > > also fixes a couple of spots which were calling spk_synth_immediate directly,
> > > so that the calls now happen via the spk_syth struct.
> > > 
> > > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> > > Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > > 
> > > Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
> > 
> > This patch doesn't apply to my tree at all.  The first 3 applied with
> > some fuzz, so I think you are not working against linux-next. Please
> > rebase your patch against linux-next, or my staging-testing branch, and
> > resend so I can apply it.
> 
> Sure, will rebase against staging-testing. Just this patch or the
> patch set?

I applied the first 3, so if you rebase, they should just "go away" :)

thanks,

greg k-h