From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbdCPMZo (ORCPT ); Thu, 16 Mar 2017 08:25:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:43176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbdCPMZm (ORCPT ); Thu, 16 Mar 2017 08:25:42 -0400 Date: Thu, 16 Mar 2017 09:25:17 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Michael Ellerman , mingo@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks Message-ID: <20170316122517.GR12825@kernel.org> References: <20170223234634.583-1-andi@firstfloor.org> <87zigmt18q.fsf@concordia.ellerman.id.au> <20170316022218.GE14380@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170316022218.GE14380@two.firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Mar 15, 2017 at 07:22:18PM -0700, Andi Kleen escreveu: > > > + memset(&al, 0, sizeof(al)); > > > + if (end - start > MAXBB - MAXINSN) { > > > + if (last) > > > + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n", > > > + start, end); > > > + else > > > + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", > > Thanks. Should be %" PRIu64 " of course. > > Arnaldo, can you do the change Done. > or should I send a patch? - Arnaldo