From: Greg KH <gregkh@linuxfoundation.org>
To: Mohsin Shan <mohsinshan1k@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
educha997@gmail.com
Subject: Re: [PATCH] Staging: goldfish: use __func__ instead of embedded function names v3
Date: Thu, 16 Mar 2017 22:28:41 +0900 [thread overview]
Message-ID: <20170316132841.GC10184@kroah.com> (raw)
In-Reply-To: <1489663554-2421-1-git-send-email-mohsinshan1k@gmail.com>
On Thu, Mar 16, 2017 at 04:25:54AM -0700, Mohsin Shan wrote:
> Embedded function names are less appropriate to use when
> refactoring, can cause function renaming. Prefer the use
> of "%s", __func__ to embedded function names
>
> Signed-off-by: Mohsin Shan <mohsinshan1k@gmail.com>
> ---
> drivers/staging/goldfish/goldfish_nand.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Please read Documenation/SubmittingPatches in the section that describes
how to version your patch properly.
v4? :)
thanks,
greg k-h
prev parent reply other threads:[~2017-03-16 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 11:25 [PATCH] Staging: goldfish: use __func__ instead of embedded function names v3 Mohsin Shan
2017-03-16 13:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316132841.GC10184@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=educha997@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsinshan1k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox