From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247AbdCPN3A (ORCPT ); Thu, 16 Mar 2017 09:29:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53574 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752205AbdCPN25 (ORCPT ); Thu, 16 Mar 2017 09:28:57 -0400 Date: Thu, 16 Mar 2017 22:28:41 +0900 From: Greg KH To: Mohsin Shan Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, educha997@gmail.com Subject: Re: [PATCH] Staging: goldfish: use __func__ instead of embedded function names v3 Message-ID: <20170316132841.GC10184@kroah.com> References: <1489663554-2421-1-git-send-email-mohsinshan1k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489663554-2421-1-git-send-email-mohsinshan1k@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 04:25:54AM -0700, Mohsin Shan wrote: > Embedded function names are less appropriate to use when > refactoring, can cause function renaming. Prefer the use > of "%s", __func__ to embedded function names > > Signed-off-by: Mohsin Shan > --- > drivers/staging/goldfish/goldfish_nand.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Please read Documenation/SubmittingPatches in the section that describes how to version your patch properly. v4? :) thanks, greg k-h