From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754746AbdCPPYS (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 11:24:18 -0400
Received: from muru.com ([72.249.23.125]:39886 "EHLO muru.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752111AbdCPPYP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 11:24:15 -0400
Date: Thu, 16 Mar 2017 08:24:06 -0700
From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: paul@pwsan.com, bcousson@baylibre.com, t-kristo@ti.com, nsekhar@ti.com,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: OMAP2+ hwmod: Allow modules to disable HW_AUTO
Message-ID: <20170316152405.GN20572@atomide.com>
References: <1489405996-10718-1-git-send-email-rogerq@ti.com>
 <1489405996-10718-3-git-send-email-rogerq@ti.com>
 <20170314154843.GD20572@atomide.com>
 <1ffd0881-9076-04b0-62bf-85b02dd7bbf3@ti.com>
 <328f9510-49bb-294c-40fd-ad0167101a50@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <328f9510-49bb-294c-40fd-ad0167101a50@ti.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Roger Quadros <rogerq@ti.com> [170316 01:06]:
> On 16/03/17 09:59, Roger Quadros wrote:
> > Tony,
> > 
> > On 14/03/17 17:48, Tony Lindgren wrote:
> >> * Roger Quadros <rogerq@ti.com> [170313 04:55]:
> >>
> >>> --- a/arch/arm/mach-omap2/omap_hwmod.c
> >>> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> >>> @@ -2149,7 +2149,7 @@ static int _idle(struct omap_hwmod *oh)
> >>>  		_idle_sysc(oh);
> >>>  	_del_initiator_dep(oh, mpu_oh);
> >>>  
> >>> -	if (oh->clkdm)
> >>> +	if (oh->clkdm && !(oh->flags & HWMOD_CLKDM_NOAUTO))
> >>>  		clkdm_deny_idle(oh->clkdm);
> >>>  
> >>>  	if (oh->flags & HWMOD_BLOCK_WFI)
> >>
> >> Is this change to _idle() really needed? It seems that the
> >> clkdm_deny_idle() there is paired with the clkdm_allow_idle()
> >> later on in the same function?
> >>
> > 
> > You are right. This change to _idle() is unnecessary. I'll send an update.
> > 
> 
> Now I remember why I put it there.
> 
> When HWMOD_CLKDM_NOAUTO flag is set, _enable() does not
> call clkdm_allow_idle() so the call to clkdm_deny_idle() in _idle() would
> be redundant.
> 
> I think we should keep the patch as it is. What do you say?

OK. Maybe add a comment there about that?

Regards,

Tony