From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932090AbdCPQ1p (ORCPT ); Thu, 16 Mar 2017 12:27:45 -0400 Received: from mga07.intel.com ([134.134.136.100]:14215 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932073AbdCPQ1o (ORCPT ); Thu, 16 Mar 2017 12:27:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,173,1486454400"; d="scan'208";a="61286584" Date: Thu, 16 Mar 2017 09:27:37 -0700 From: Andi Kleen To: Dmitry Vyukov Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , "linux-mm@kvack.org" , "x86@kernel.org" , LKML Subject: Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error Message-ID: <20170316162737.GJ32070@tassilo.jf.intel.com> References: <20170316044704.GA729@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Andi, why did you completely remove __arch_atomic_add_unless() from > the header? Don't we need at least a declaration there? Yes the declaration should be there. I'll send a new patch. -Andi