From: Greg KH <gregkh@linuxfoundation.org>
To: sunil.m@techveda.org
Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
karthiknishu@yahoo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks
Date: Fri, 17 Mar 2017 15:16:59 +0900 [thread overview]
Message-ID: <20170317061659.GA18373@kroah.com> (raw)
In-Reply-To: <1489702341-14448-1-git-send-email-sunil.m@techveda.org>
On Fri, Mar 17, 2017 at 03:42:15AM +0530, sunil.m@techveda.org wrote:
> From: Suniel Mahesh <sunil.m@techveda.org>
>
> Split earlier patches into multiple commits for easy review as
> suggested by Dan Carpenter.
> Modified subject, description and in few patches both for
> better readability as suggested by Greg KH.
> Dropped two patches from the earler series, as they were not adding
> significant value, suggested by Dan Carpenter.
> Fixed the following issues reported by checkpatch.pl:
> Block comments should align the * on each line, aligned.
> Block comments use * on subsequent lines, other characters
> are replaced by * .
> Removed unnecessary 'out of memory' message.
> Comparison's to NULL could be written '!foo' or 'foo', modified.
> Replaced sizeof(struct foo) into sizeof(*ptr).
> Spaces preferred around that 'operator', spacing provided.
> Logical continuations should be on the previous line, modified accordingly.
> Unnecessary parentheses around variables, removed.
> Please use a blank line after function/struct/union/enum declarations, used.
> Blank lines aren't necessary after an open brace '{' and before a
> close brace '}', removed.
> No space is necessary after a cast, removed.
> Please don't use multiple blank lines, removed.
I have no idea what all of this means :(
Can you resend the full series, not just random patches in a series? I
don't have any of the old ones anymore.
If I have applied other patches, just send this as a sequence that is
numbered properly, with all of the patches to be applied.
You need to make it very easy for a maintainer to know what to do here,
remember, we have no short-term memory of any previous submissions.
thanks,
greg k-h
next prev parent reply other threads:[~2017-03-17 6:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 7:09 [PATCH] staging: rtl8192e: fix coding style issue, improve error handling Suniel Mahesh
2017-03-07 17:12 ` Dan Carpenter
2017-03-09 18:50 ` [PATCH v2 0/5] staging: rtl8192e: Fix coding style, warnings and checks sunil.m
2017-03-09 18:50 ` [PATCH v2 1/5] staging: rtl8192e: Fix coding style issues sunil.m
2017-03-11 8:11 ` kbuild test robot
2017-03-12 13:41 ` Greg KH
2017-03-15 9:51 ` [PATCH v3 0/8] staging: rtl8192e: Fix coding style, warnings and checks sunil.m
2017-03-15 9:51 ` [PATCH v3 1/8] staging: rtl8192e: Fix comments as per kernel coding style sunil.m
2017-03-15 9:51 ` [PATCH v3 2/8] staging: rtl8192e: Fix " sunil.m
2017-03-15 10:14 ` Dan Carpenter
2017-03-15 11:09 ` Suniel Mahesh
2017-03-15 11:15 ` Dan Carpenter
2017-03-15 10:15 ` Dan Carpenter
2017-03-15 9:51 ` [PATCH v3 3/8] staging: rtl8192e: Remove unnecessary 'out of memory' message sunil.m
2017-03-15 10:16 ` Dan Carpenter
2017-03-15 10:58 ` [PATCH v4 " sunil.m
2017-03-16 2:36 ` Greg KH
2017-03-16 22:12 ` [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks sunil.m
2017-03-16 22:12 ` [PATCH v4 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m
2017-03-16 22:12 ` [PATCH v4 6/6] staging: rtl8192e: Fix blank lines and space after a cast sunil.m
2017-03-17 6:16 ` Greg KH [this message]
2017-03-21 9:00 ` [PATCH v5 0/6] staging: rtl8192e: Fix coding style, warnings and checks suniel.spartan
2017-03-21 9:01 ` [PATCH v5 1/6] staging: rtl8192e: Fix comments as per kernel coding style suniel.spartan
2017-03-21 9:01 ` [PATCH v5 2/6] staging: rtl8192e: Remove unnecessary 'out of memory' message suniel.spartan
2017-03-21 9:01 ` [PATCH v5 3/6] staging: rtl8192e: Rectify pointer comparisions with NULL suniel.spartan
2017-03-21 9:01 ` [PATCH v5 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct suniel.spartan
2017-03-21 9:01 ` [PATCH v5 5/6] staging: rtl8192e: Fix issues reported by checkpatch.pl suniel.spartan
2017-03-21 9:01 ` [PATCH v5 6/6] staging: rtl8192e: Fix blank lines and space after a cast suniel.spartan
2017-03-15 9:51 ` [PATCH v3 4/8] staging: rtl8192e: Rectify pointer comparisions with NULL sunil.m
2017-03-15 9:51 ` [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces sunil.m
2017-03-15 10:24 ` Dan Carpenter
2017-03-15 9:51 ` [PATCH v3 6/8] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m
2017-03-15 9:51 ` [PATCH v3 7/8] staging: rtl8192e: Fix issues reported by checkpatch.pl sunil.m
2017-03-15 9:51 ` [PATCH v3 8/8] staging: rtl8192e: Fix blank lines and space after a cast sunil.m
2017-03-09 18:50 ` [PATCH v2 2/5] staging: rtl8192e: Improve error handling sunil.m
2017-03-09 18:50 ` [PATCH v2 3/5] staging: rtl8192e: Rectify pointer comparisions sunil.m
2017-03-09 18:50 ` [PATCH v2 4/5] staging: rtl8192e: Fix unbalanced braces around else statement sunil.m
2017-03-09 18:50 ` [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m
2017-03-17 9:58 ` Suniel Mahesh
2017-03-09 18:50 ` [PATCH] staging: rtl8192e: fix coding style issue, improve error handling kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317061659.GA18373@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=karthiknishu@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunil.m@techveda.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox