linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Jens Axboe <axboe@fb.com>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Cc: Yi Zhang <yizhan@redhat.com>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	Ming Lei <tom.leiming@gmail.com>, Tejun Heo <tj@kernel.org>
Subject: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting dying
Date: Fri, 17 Mar 2017 17:57:11 +0800	[thread overview]
Message-ID: <20170317095711.5819-4-tom.leiming@gmail.com> (raw)
In-Reply-To: <20170317095711.5819-1-tom.leiming@gmail.com>

Before commit 780db2071a(blk-mq: decouble blk-mq freezing
from generic bypassing), the dying flag is checked before
entering queue, and Tejun converts the checking into .mq_freeze_depth,
and assumes the counter is increased just after dying flag
is set. Unfortunately we doesn't do that in blk_set_queue_dying().

This patch calls blk_mq_freeze_queue_start() for blk-mq in
blk_set_queue_dying(), so that we can block new I/O coming
once the queue is set as dying.

Given blk_set_queue_dying() is always called in remove path
of block device, and queue will be cleaned up later, we don't
need to worry about undoing the counter.

Cc: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 block/blk-core.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index d772c221cc17..62d4967c369f 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -500,9 +500,12 @@ void blk_set_queue_dying(struct request_queue *q)
 	queue_flag_set(QUEUE_FLAG_DYING, q);
 	spin_unlock_irq(q->queue_lock);
 
-	if (q->mq_ops)
+	if (q->mq_ops) {
 		blk_mq_wake_waiters(q);
-	else {
+
+		/* block new I/O coming */
+		blk_mq_freeze_queue_start(q);
+	} else {
 		struct request_list *rl;
 
 		spin_lock_irq(q->queue_lock);
-- 
2.9.3

  parent reply	other threads:[~2017-03-17  9:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17  9:57 [PATCH v1 0/3] blk-mq: dying queue fix & improvement Ming Lei
2017-03-17  9:57 ` [PATCH v1 1/3] blk-mq: don't complete un-started request in timeout handler Ming Lei
2017-03-18 11:24   ` Hannes Reinecke
2017-03-17  9:57 ` [PATCH v1 2/3] blk-mq: comment on races related with " Ming Lei
2017-03-17 17:39   ` Bart Van Assche
2017-03-17 18:23     ` Ming Lei
2017-03-18 11:25   ` Hannes Reinecke
2017-03-17  9:57 ` Ming Lei [this message]
2017-03-17 17:32   ` [PATCH v1 3/3] blk-mq: start to freeze queue just after setting dying Bart Van Assche
2017-03-17 18:32     ` Ming Lei
2017-03-17 20:36       ` Bart Van Assche
2017-03-17 23:26   ` Bart Van Assche
2017-03-18  1:01     ` Ming Lei
2017-03-18 11:27   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170317095711.5819-4-tom.leiming@gmail.com \
    --to=tom.leiming@gmail.com \
    --cc=axboe@fb.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yizhan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).