From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751094AbdCQLwF (ORCPT ); Fri, 17 Mar 2017 07:52:05 -0400 Received: from mail.us.es ([193.147.175.20]:56510 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdCQLwD (ORCPT ); Fri, 17 Mar 2017 07:52:03 -0400 Date: Fri, 17 Mar 2017 12:50:41 +0100 From: Pablo Neira Ayuso To: "Reshetova, Elena" Cc: "netfilter-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kadlec@blackhole.kfki.hu" , "peterz@infradead.org" , "keescook@chromium.org" Subject: Re: [PATCH 0/7] net, netfilter refcounter conversions Message-ID: <20170317115041.GA4979@salvia> References: <1489576245-19472-1-git-send-email-elena.reshetova@intel.com> <20170315130213.GA30233@salvia> <2236FBA76BA1254E88B949DDB74E612B41C59A26@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B41C59A26@IRSMSX102.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 07:52:19AM +0000, Reshetova, Elena wrote: > > > On Wed, Mar 15, 2017 at 01:10:38PM +0200, Elena Reshetova wrote: > > > This series, for the netfilter subsystem, replaces atomic_t reference > > > counters with the new refcount_t type and API (see include/linux/refcount.h). > > > By doing this we prevent intentional or accidental > > > underflows or overflows that can led to use-after-free vulnerabilities. > > > > > > Please take the series to your tree if there are no run-time issues. > > > > Could you collapse all of your patches into one single? They are all > > part of the same logical change to me. > > > > > 21 files changed, 85 insertions(+), 75 deletions(-) > > > > The diffstat is small enough to do what I'm asking. > > Sure. The reason why they are separated is that it is easier to > review them this way IMO and find mistakes (I found many after I > split all networking patches into one per variable). But I guess > for merge, it is easier to have them collapsed, so I am going to > send you a new version shortly. In my particular case, collapsing them is good so the Netfilter batch I pass up to David becomes smaller. Thanks!