From: Johan Hovold <johan@kernel.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wolfram Sang <wsa-dev@sang-engineering.com>,
Dave Penkler <dpenkler@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] usbtmc: don't return zero on failure path in usbtmc_probe()
Date: Sat, 18 Mar 2017 09:54:59 +0100 [thread overview]
Message-ID: <20170318085459.GA11134@localhost> (raw)
In-Reply-To: <1489793880-14284-1-git-send-email-khoroshilov@ispras.ru>
On Sat, Mar 18, 2017 at 02:38:00AM +0300, Alexey Khoroshilov wrote:
> usbtmc_probe() returns zero in case of allocation failures.
>
> The patch fixes that. By the way it rearranges error lables just to improve
> readability of quite complex dependencies in error handling code.
This was in fact fixed earlier this week by commit 2e47c53503eb ("USB:
usbtmc: fix probe error path") in Greg's usb-linus branch.
The current error label is indeed confusingly named, but that can be
addressed by a follow-on clean-up patch. Note that naming error labels
after what they do (e.g. err_remove_capability) is generally preferred.
Thanks,
Johan
prev parent reply other threads:[~2017-03-18 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 23:38 [PATCH] usbtmc: don't return zero on failure path in usbtmc_probe() Alexey Khoroshilov
2017-03-18 8:54 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170318085459.GA11134@localhost \
--to=johan@kernel.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox