From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208AbdCRJG6 (ORCPT ); Sat, 18 Mar 2017 05:06:58 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36768 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbdCRJG4 (ORCPT ); Sat, 18 Mar 2017 05:06:56 -0400 From: Ding-Chi Wang X-Google-Original-From: Ding-Chi Wang Date: Sat, 18 Mar 2017 16:59:14 +0800 To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Jannik Becher , Derek Robson , Parth Sane , Bhaktipriya Shridhar , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8712: checkpatch: Avoid multiple line dereferences Message-ID: <20170318085911.GA5868@vm> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Antivirus: avast! (VPS 170317-4, 2017/03/17), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2I977I7009244 "WARNING: Avoid multiple line dereference - prefer 'poid_par_priv->information_buf_len'" "WARNING: Avoid multiple line dereference - prefer 'padapter->registrypriv.dev_network.Configuration'" "WARNING: Avoid multiple line dereference - prefer 'Adapter->mppriv.workparam.io_value'" Signed-off-by: Ding-Chi Wang --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_rtl.c b/drivers/staging/rtl8712/rtl871x_ioctl_rtl.c index c7f2e51..ca769f7 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_rtl.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_rtl.c @@ -282,8 +282,7 @@ uint oid_rt_get_total_rx_bytes_hdl(struct oid_par_priv if (poid_par_priv->information_buf_len >= sizeof(u32)) { *(u32 *)poid_par_priv->information_buf = padapter->recvpriv.rx_bytes; - *poid_par_priv->bytes_rw = poid_par_priv-> - information_buf_len; + *poid_par_priv->bytes_rw = poid_par_priv->information_buf_len; } else { return RNDIS_STATUS_INVALID_LENGTH; } @@ -325,8 +324,7 @@ uint oid_rt_get_channel_hdl(struct oid_par_priv *poid_par_priv) check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) pnic_Config = &pmlmepriv->cur_network.network.Configuration; else - pnic_Config = &padapter->registrypriv.dev_network. - Configuration; + pnic_Config = &padapter->registrypriv.dev_network.Configuration; channelnum = pnic_Config->DSConfig; *(u32 *)poid_par_priv->information_buf = channelnum; *poid_par_priv->bytes_rw = poid_par_priv->information_buf_len; @@ -483,8 +481,8 @@ uint oid_rt_pro_rf_read_registry_hdl(struct oid_par_priv *poid_par_priv) */ if (!r8712_getrfreg_cmd(Adapter, *(unsigned char *)poid_par_priv->information_buf, - (unsigned char *)&Adapter->mppriv.workparam. - io_value)) + (unsigned char *)&Adapter->mppriv.workparam.io_value + )) status = RNDIS_STATUS_NOT_ACCEPTED; } } else { -- 1.9.1 --- Avast 防毒軟體已檢查此封電子郵件的病毒。 https://www.avast.com/antivirus