Re: [PATCH tip] x86/mm: Correct fixmap header usage on adaptable MODULES_END

Wei Yang
2017-03-20T16:53:25Z

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

On Mon, Mar 20, 2017 at 07:31:17AM -0700, Thomas Garnier wrote:
>On Sun, Mar 19, 2017 at 6:14 PM, Wei Yang <richard.weiyang@gmail.com> wrote:
>> On Sun, Mar 19, 2017 at 09:25:00AM -0700, Thomas Garnier wrote:
>>>On Sun, Mar 19, 2017 at 9:03 AM, Wei Yang <richard.weiyang@gmail.com> wrote:
>>>> On Fri, Mar 17, 2017 at 10:50:34AM -0700, Thomas Garnier wrote:
>>>>>This patch remove fixmap header usage on non-x86 code that was
>>>>>introduced by the adaptable MODULE_END change.
>>>>
>>>> Hi, Thomas
>>>>
>>>> In this patch, it looks you are trying to do two things for my understanding:
>>>> 1. To include <asm/fixmap.h> in asm/pagetable_64.h and remove the include in
>>>> some of the x86 files
>>>> 2. Remove <asm/fixmap.h> in mm/vmalloc.c
>>>>
>>>> I think your change log covers the second task in the patch, but not not talk
>>>> about the first task you did in the patch. If you could mention it in commit
>>>> log, it would be good for maintain.
>>>
>>>I agree, I am not the best at writing commits (by far). What's the
>>>best way for me to correct that? (the bot seem to have taken it).
>>>
>>
>> Simply mention it in your commit log is enough to me.
>>
>
>I meant, do I send another patch or reply on in this thread and bot
>will pick it up?
>

I think it is necessary to send V2.

--
Wei Yang
Help you, Help me

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]