From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754648AbdCTMQe (ORCPT ); Mon, 20 Mar 2017 08:16:34 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44919 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715AbdCTMQ2 (ORCPT ); Mon, 20 Mar 2017 08:16:28 -0400 X-ME-Sender: X-Sasl-enc: 0Rcvdvix3Ls7iA3HWt3VrvnCkwGHkuKvk8JD4jIBZRmA 1490012181 Date: Mon, 20 Mar 2017 14:16:19 +0200 From: Ido Schimmel To: Colin King Cc: Jiri Pirko , Ido Schimmel , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes Message-ID: <20170320121619.GA12091@splinter.mtl.com> References: <20170320113722.30311-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320113722.30311-1-colin.king@canonical.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2017 at 11:37:22AM +0000, Colin King wrote: > From: Colin Ian King > > The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are > in the wrong order. Fix this by swapping them. > > Detected by CoverityScan, CID#1419705 ("Arguments in wrong order") > > Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics") Only need first 12 characters. > Signed-off-by: Colin Ian King Acked-by: Ido Schimmel Thanks!