From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352AbdCTObv (ORCPT ); Mon, 20 Mar 2017 10:31:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58800 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669AbdCTObd (ORCPT ); Mon, 20 Mar 2017 10:31:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1F811635F9 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1F811635F9 Date: Mon, 20 Mar 2017 09:04:25 -0500 From: Josh Poimboeuf To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Masami Hiramatsu , "H. Peter Anvin" , Andy Lutomirski , Linus Torvalds Subject: Re: [PATCH 6/6 v3] ftrace/x86: Use Makefile logic instead of #ifdef of compling ftrace_*.o Message-ID: <20170320140425.oirnr2oce4d2qlcw@treble> References: <20170318210923.814509382@goodmis.org> <20170318211149.740427022@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170318211149.740427022@goodmis.org> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 20 Mar 2017 14:04:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 18, 2017 at 05:09:29PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Currently ftrace_32.S and ftrace_64.S are compiled even when > CONFIG_FUNCTION_TRACER is not set. This means there's an unnecessary #ifdef > to protect the code. Instead of using preprocessor directives, only compile > those files when FUNCTION_TRACER is defined. > > Link: http://lkml.kernel.org/r/20170316210043.peycxdxktwwn6cid@treble > Suggested-by: Josh Poimboeuf > Signed-off-by: Steven Rostedt (VMware) The subject has a typo ("compling") and would parse better if the second "of" where changed to a "for": "for compiling". Otherwise: Reviewed-by: Josh Poimboeuf -- Josh