From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106AbdCTRwg (ORCPT ); Mon, 20 Mar 2017 13:52:36 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47132 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756086AbdCTRwb (ORCPT ); Mon, 20 Mar 2017 13:52:31 -0400 Date: Mon, 20 Mar 2017 10:52:29 -0700 From: Christoph Hellwig To: David Howells Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Add statx support Message-ID: <20170320175229.GA26784@infradead.org> References: <148966413352.3279.15659219505999889147.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148966413352.3279.15659219505999889147.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 11:35:33AM +0000, David Howells wrote: > Return enhanced file attributes from the Ext4 filesystem. This includes > the following: Just as the comment to a similar patch from Darrick for XFS: Please add test cases that verify this information. Especially in the light of the races mentioned in the discussion later. If we can't get tests for statx before 4.11 is getting close to release I fear we'll have to revert it - untested syscalls have a tendency to be broken and create problems for the future.