[PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,
@ 2017-03-19 13:14 Arushi Singhal
  2017-03-19 13:14 ` [PATCH v2 1/2] staging: speakup: Moved OR operator to previous line Arushi Singhal
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Arushi Singhal @ 2017-03-19 13:14 UTC (permalink / raw)
  To: w.d.hubbs
  Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
	devel, linux-kernel, Arushi Singhal

Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.

Arushi Singhal (2):
  staging: speakup: Moved OR operator to previous line.
  staging: speakup: spaces preferred around operator

 drivers/staging/speakup/main.c           |  8 ++++----
 drivers/staging/speakup/speakup.h        | 12 ++++++------
 drivers/staging/speakup/speakup_acntpc.c |  2 +-
 drivers/staging/speakup/speakup_decpc.c  | 20 ++++++++++----------
 drivers/staging/speakup/speakup_dtlk.c   |  2 +-
 drivers/staging/speakup/speakup_keypc.c  |  6 +++---
 drivers/staging/speakup/speakup_ltlk.c   |  2 +-
 7 files changed, 26 insertions(+), 26 deletions(-)

-- 
changes in v2
 - correct the commit message of [PATCH 1/2]
2.11.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] staging: speakup: Moved OR operator to previous line.
  2017-03-19 13:14 [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Arushi Singhal
@ 2017-03-19 13:14 ` Arushi Singhal
  2017-03-19 13:14 ` [PATCH v2 2/2] staging: speakup: spaces preferred around operator Arushi Singhal
  2017-03-21  6:11 ` [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Greg KH
  2 siblings, 0 replies; 5+ messages in thread
From: Arushi Singhal @ 2017-03-19 13:14 UTC (permalink / raw)
  To: w.d.hubbs
  Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
	devel, linux-kernel, Arushi Singhal

Moved logical OR operator to previous line to fix the following
checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
  -change the commit message and subject.

 drivers/staging/speakup/main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index c10445624e92..def1a36da9dd 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2173,10 +2173,10 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
 	if (up_flag || spk_killed || type == KT_SHIFT)
 		goto out;
 	spk_shut_up &= 0xfe;
-	kh = (value == KVAL(K_DOWN))
-	    || (value == KVAL(K_UP))
-	    || (value == KVAL(K_LEFT))
-	    || (value == KVAL(K_RIGHT));
+	kh = (value == KVAL(K_DOWN)) ||
+	    (value == KVAL(K_UP)) ||
+	    (value == KVAL(K_LEFT)) ||
+	    (value == KVAL(K_RIGHT));
 	if ((cursor_track != read_all_mode) || !kh)
 		if (!spk_no_intr)
 			spk_do_flush();
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] staging: speakup: spaces preferred around operator
  2017-03-19 13:14 [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Arushi Singhal
  2017-03-19 13:14 ` [PATCH v2 1/2] staging: speakup: Moved OR operator to previous line Arushi Singhal
@ 2017-03-19 13:14 ` Arushi Singhal
  2017-03-21  6:11 ` [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Greg KH
  2 siblings, 0 replies; 5+ messages in thread
From: Arushi Singhal @ 2017-03-19 13:14 UTC (permalink / raw)
  To: w.d.hubbs
  Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
	devel, linux-kernel, Arushi Singhal

Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
 -no change.

 drivers/staging/speakup/speakup.h        | 12 ++++++------
 drivers/staging/speakup/speakup_acntpc.c |  2 +-
 drivers/staging/speakup/speakup_decpc.c  | 20 ++++++++++----------
 drivers/staging/speakup/speakup_dtlk.c   |  2 +-
 drivers/staging/speakup/speakup_keypc.c  |  6 +++---
 drivers/staging/speakup/speakup_ltlk.c   |  2 +-
 6 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/speakup/speakup.h b/drivers/staging/speakup/speakup.h
index 0bc8d6afadfa..a654334c98b9 100644
--- a/drivers/staging/speakup/speakup.h
+++ b/drivers/staging/speakup/speakup.h
@@ -20,7 +20,7 @@
 #define A_CAP 0x0007
 #define B_NUM 0x0008
 #define NUM 0x0009
-#define ALPHANUM (B_ALPHA|B_NUM)
+#define ALPHANUM (B_ALPHA | B_NUM)
 #define SOME 0x0010
 #define MOST 0x0020
 #define PUNC 0x0040
@@ -30,14 +30,14 @@
 #define B_EXNUM 0x0100
 #define CH_RPT 0x0200
 #define B_CTL 0x0400
-#define A_CTL (B_CTL+SYNTH_OK)
+#define A_CTL (B_CTL + SYNTH_OK)
 #define B_SYM 0x0800
-#define B_CAPSYM (B_CAP|B_SYM)
+#define B_CAPSYM (B_CAP | B_SYM)
 
 /* FIXME: u16 */
-#define IS_WDLM(x) (spk_chartab[((u_char)x)]&B_WDLM)
-#define IS_CHAR(x, type) (spk_chartab[((u_char)x)]&type)
-#define IS_TYPE(x, type) ((spk_chartab[((u_char)x)]&type) == type)
+#define IS_WDLM(x) (spk_chartab[((u_char)x)] & B_WDLM)
+#define IS_CHAR(x, type) (spk_chartab[((u_char)x)] & type)
+#define IS_TYPE(x, type) ((spk_chartab[((u_char)x)] & type) == type)
 
 int speakup_thread(void *data);
 void spk_reset_default_chars(void);
diff --git a/drivers/staging/speakup/speakup_acntpc.c b/drivers/staging/speakup/speakup_acntpc.c
index c5beb5602c42..b4058bd82e42 100644
--- a/drivers/staging/speakup/speakup_acntpc.c
+++ b/drivers/staging/speakup/speakup_acntpc.c
@@ -282,7 +282,7 @@ static int synth_probe(struct spk_synth *synth)
 			if (port_val == 0x53fc) {
 				/* 'S' and out&input bits */
 				synth_port_control = synth_portlist[i];
-				speakup_info.port_tts = synth_port_control+1;
+				speakup_info.port_tts = synth_port_control + 1;
 				break;
 			}
 		}
diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 5e35d7e11361..5d22c3b7edd4 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -250,7 +250,7 @@ static int dt_getstatus(void)
 static void dt_sendcmd(u_int cmd)
 {
 	outb_p(cmd & 0xFF, speakup_info.port_tts);
-	outb_p((cmd >> 8) & 0xFF, speakup_info.port_tts+1);
+	outb_p((cmd >> 8) & 0xFF, speakup_info.port_tts + 1);
 }
 
 static int dt_waitbit(int bit)
@@ -286,11 +286,11 @@ static int dt_ctrl(u_int cmd)
 
 	if (!dt_waitbit(STAT_cmd_ready))
 		return -1;
-	outb_p(0, speakup_info.port_tts+2);
-	outb_p(0, speakup_info.port_tts+3);
+	outb_p(0, speakup_info.port_tts + 2);
+	outb_p(0, speakup_info.port_tts + 3);
 	dt_getstatus();
-	dt_sendcmd(CMD_control|cmd);
-	outb_p(0, speakup_info.port_tts+6);
+	dt_sendcmd(CMD_control | cmd);
+	outb_p(0, speakup_info.port_tts + 6);
 	while (dt_getstatus() & STAT_cmd_ready) {
 		udelay(20);
 		if (--timeout == 0)
@@ -318,8 +318,8 @@ udelay(50);
 			break;
 udelay(50);
 	}
-	outb_p(DMA_sync, speakup_info.port_tts+4);
-	outb_p(0, speakup_info.port_tts+4);
+	outb_p(DMA_sync, speakup_info.port_tts + 4);
+	outb_p(0, speakup_info.port_tts + 4);
 	udelay(100);
 	for (timeout = 0; timeout < 10; timeout++) {
 		if (!(dt_getstatus() & STAT_flushing))
@@ -337,8 +337,8 @@ static int dt_sendchar(char ch)
 		return -1;
 	if (!(dt_stat & STAT_rr_char))
 		return -2;
-	outb_p(DMA_single_in, speakup_info.port_tts+4);
-	outb_p(ch, speakup_info.port_tts+4);
+	outb_p(DMA_single_in, speakup_info.port_tts + 4);
+	outb_p(ch, speakup_info.port_tts + 4);
 	dma_state ^= STAT_dma_state;
 	return 0;
 }
@@ -354,7 +354,7 @@ static int testkernel(void)
 	dt_sendcmd(CMD_sync);
 	if (!dt_waitbit(STAT_cmd_ready))
 		status = -2;
-	else if (dt_stat&0x8000)
+	else if (dt_stat & 0x8000)
 		return 0;
 	else if (dt_stat == 0x0dec)
 		pr_warn("dec_pc at 0x%x, software not loaded\n",
diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c
index 693fac4365c3..5973acc0a006 100644
--- a/drivers/staging/speakup/speakup_dtlk.c
+++ b/drivers/staging/speakup/speakup_dtlk.c
@@ -300,7 +300,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)
 	t += 2;
 	for (i = 0; *t != '\r'; t++) {
 		status.rom_version[i] = *t;
-		if (i < sizeof(status.rom_version)-1)
+		if (i < sizeof(status.rom_version) - 1)
 			i++;
 	}
 	status.rom_version[i] = 0;
diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
index 6649fa4c0ad2..ba7901178e0b 100644
--- a/drivers/staging/speakup/speakup_keypc.c
+++ b/drivers/staging/speakup/speakup_keypc.c
@@ -142,9 +142,9 @@ static char *oops(void)
 	int s1, s2, s3, s4;
 
 	s1 = inb_p(synth_port);
-	s2 = inb_p(synth_port+1);
-	s3 = inb_p(synth_port+2);
-	s4 = inb_p(synth_port+3);
+	s2 = inb_p(synth_port + 1);
+	s3 = inb_p(synth_port + 2);
+	s4 = inb_p(synth_port + 3);
 	pr_warn("synth timeout %d %d %d %d\n", s1, s2, s3, s4);
 	return NULL;
 }
diff --git a/drivers/staging/speakup/speakup_ltlk.c b/drivers/staging/speakup/speakup_ltlk.c
index cb4f2958c318..11275f49bea4 100644
--- a/drivers/staging/speakup/speakup_ltlk.c
+++ b/drivers/staging/speakup/speakup_ltlk.c
@@ -145,7 +145,7 @@ static void synth_interrogate(struct spk_synth *synth)
 		if (i > 2 && buf[i] == 0x7f)
 			break;
 	}
-	t = buf+2;
+	t = buf + 2;
 	for (i = 0; *t != '\r'; t++) {
 		rom_v[i] = *t;
 		if (++i >= 19)
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,
  2017-03-19 13:14 [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Arushi Singhal
  2017-03-19 13:14 ` [PATCH v2 1/2] staging: speakup: Moved OR operator to previous line Arushi Singhal
  2017-03-19 13:14 ` [PATCH v2 2/2] staging: speakup: spaces preferred around operator Arushi Singhal
@ 2017-03-21  6:11 ` Greg KH
       [not found]   ` <CA+XqjF_MC042ev5H1h4=4C7NNH1wJFyWxtekOtRe9Yybik2=-w@mail.gmail.com>
  2 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2017-03-21  6:11 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: w.d.hubbs, chris, outreachy-kernel, kirk, samuel.thibault,
	speakup, devel, linux-kernel

On Sun, Mar 19, 2017 at 06:44:53PM +0530, Arushi Singhal wrote:
> Improve readability by fixing multiple checkpatch.pl
> issues in speakup driver.
> 
> Arushi Singhal (2):
>   staging: speakup: Moved OR operator to previous line.
>   staging: speakup: spaces preferred around operator

You have sent many different speakup patches, in different series, and
then a bunch of individual patches all at once.  I have no idea what to
apply here, what order they go in, or even which ones should be
reviewed.

So I've dropped all of them from my patch queue.  Please resend all of
your outstanding speakup patches, in a _single_ patch series, so that
they can be reviewed in the correct order.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <CA+XqjF_MC042ev5H1h4=4C7NNH1wJFyWxtekOtRe9Yybik2=-w@mail.gmail.com>]

* Re: [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,
       [not found]   ` <CA+XqjF_MC042ev5H1h4=4C7NNH1wJFyWxtekOtRe9Yybik2=-w@mail.gmail.com>
@ 2017-03-21  6:55     ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2017-03-21  6:55 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: William Hubbs, Chris Brannon, outreachy-kernel, Kirk Reiser,
	Samuel Thibault, speakup, driverdevel, linux-kernel

On Tue, Mar 21, 2017 at 12:03:50PM +0530, Arushi Singhal wrote:
> 
> 
> On Tue, Mar 21, 2017 at 11:41 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
>     On Sun, Mar 19, 2017 at 06:44:53PM +0530, Arushi Singhal wrote:
>     > Improve readability by fixing multiple checkpatch.pl
>     > issues in speakup driver.
>     >
>     > Arushi Singhal (2):
>     >   staging: speakup: Moved OR operator to previous line.
>     >   staging: speakup: spaces preferred around operator
> 
>     You have sent many different speakup patches, in different series, and
>     then a bunch of individual patches all at once.  I have no idea what to
>     apply here, what order they go in, or even which ones should be
>     reviewed.
> 
>     So I've dropped all of them from my patch queue.  Please resend all of
>     your outstanding speakup patches, in a _single_ patch series, so that
>     they can be reviewed in the correct order.
> 
> 
> Hi Greg
> I will resend them all in a single patch series.
> I just want to confirm that  whether you have droped all my patches or only
> speakup driver patches.

At this point in time, only the speakup patches.  I only see one other
pending patch from you, for the sm750fb driver, in my queue.

And don't worry about confirming or not, just resend, given the huge
numbers of patches sent for kernel development normally, there's no way
I can track what an individual does or has outstanding or has been
dropped, it's impossible.  That's up to you to manage, not me :)

Remember, I get an average of 1000 emails a day that I need to do
something with, not including mailing lists I'm subscribed to...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-03-21  6:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-19 13:14 [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Arushi Singhal
2017-03-19 13:14 ` [PATCH v2 1/2] staging: speakup: Moved OR operator to previous line Arushi Singhal
2017-03-19 13:14 ` [PATCH v2 2/2] staging: speakup: spaces preferred around operator Arushi Singhal
2017-03-21  6:11 ` [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Greg KH
     [not found]   ` <CA+XqjF_MC042ev5H1h4=4C7NNH1wJFyWxtekOtRe9Yybik2=-w@mail.gmail.com>
2017-03-21  6:55     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox