Re: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions

Jarkko Sakkinen
2017-03-23T15:51:22Z

On Tue, Mar 21, 2017 at 10:05:36PM +0000, Winkler, Tomas wrote:
> > On Thu, Mar 16, 2017 at 09:51:33PM -0400, Jérémy Lefaure wrote:
> > > When PM_SLEEP is disabled crb_pm_suspend and crb_pm_resume are not
> > > used by SET_SYSTEM_SLEEP_PM_OPS even if PM is enabled:
> > >
> > > drvers/char/tpm/tpm_crb.c:540:12: warning: ‘crb_pm_suspend’ defined
> > > but not used [-Wunused-function] static int crb_pm_suspend(struct
> > > device *dev)
> > > ^
> > > drivers/char/tpm/tpm_crb.c:551:12: warning: ‘crb_pm_resume’ defined
> > > but not used [-Wunused-function] static int crb_pm_resume(struct
> > > device *dev)
> > > ^
> > >
> > > The preprocessor condition should be on CONFIG_PM_SLEEP, not on
> > CONFIG_PM.
> > > However, this patch fixes this warning by using __maybe_unused on
> > > function that are in the preprocessor condition.
> > >
> > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> >
> > Thanks. Please include also linux-kernel@vger.kernel.org in the future.
> >
> > Reviewed-by: Jarkko Saskkinen <jarkko.sakkinen@linux.intel.com>
>
> We should go with Arnd's patch, which is actually the same, but it
> was already reviewed and has better commit messages.
> Thanks
> Tomas

You are right about the commit message but where are the Reviewed-by
tags? [1]

[1] https://patchwork.kernel.org/patch/9633537/

/Jarkko