From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933045AbdCUOwK (ORCPT ); Tue, 21 Mar 2017 10:52:10 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:33085 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbdCUOwJ (ORCPT ); Tue, 21 Mar 2017 10:52:09 -0400 Date: Tue, 21 Mar 2017 17:52:50 +0300 From: Serge Semin To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Wei Yongjun , Julia Lawall , Greg Kroah-Hartman , Colin Ian King , Dan Carpenter Subject: Re: [PATCH v2 3/3] eeprom: idt_89hpesx: Add OF device ID table Message-ID: <20170321145250.GA29906@mobilestation> References: <20170321135049.16211-1-javier@osg.samsung.com> <20170321135049.16211-3-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321135049.16211-3-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 10:50:49AM -0300, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Serge Semin